Adding an ECCO prescribed atmosphere #505
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Conflicts have risen indeed :) |
Should be all solved, I think we can merge |
navidcy
reviewed
May 12, 2025
navidcy
reviewed
May 12, 2025
|
This should be ready to go, shall we merge it? |
|
This PR should be ready to merge. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #505 +/- ##
==========================================
- Coverage 14.32% 14.17% -0.15%
==========================================
Files 48 49 +1
Lines 2953 2984 +31
==========================================
Hits 423 423
- Misses 2530 2561 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a very low-frequency atmosphere to test fluxes (or maybe for very coarse ocean simulations that would prefer to be forced by a low-frequency atmosphere). Will wait for the Copernicus PR #489 to be merged before massaging and completing this one (I am expecting some conflicts to arise)