-
Couldn't load subscription status.
- Fork 22
Implementing checkpointer for coupled model #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
taimoorsohail
wants to merge
67
commits into
main
Choose a base branch
from
ts/checkpointer-for-coupled-model
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 40 commits
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
806be1e
Added a run_coupled! function to implement checkpointers in coupled s…
taimoorsohail 46b7bb2
Added a run_coupled! function to implement checkpointers in coupled s…
taimoorsohail 75b8182
Simplified the near_global_ocean example to see why the checkpointing…
taimoorsohail 55106ba
Merge remote-tracking branch 'origin/main' into ts/checkpointer-for-c…
taimoorsohail 61f91f5
merge main;
taimoorsohail fb5d35d
Testing the set! function
navidcy e39c87a
merge main
navidcy d15439f
managed to pick up!
navidcy a0dca49
Changed checkointer_mwe.jl
taimoorsohail 8ff3748
Cleaning up checkpointer_mwe.jl file
taimoorsohail 3fdf785
extends methods to work with OSIM and OSIMSIM
navidcy 2328bb5
mwe
navidcy 9ab0df1
simplify
navidcy 5bd34f8
tidying up
navidcy 9e2af01
bit cleaner
navidcy 4f5ff2e
set!(sim::OSIMSIM{PrescribedAtmosphere})
navidcy ba2521a
cleaner mwe
navidcy b75d6e0
Changed the function to set!
taimoorsohail f1cae4f
Merge NCC changes
taimoorsohail dfb57fa
Merge NCC changes
taimoorsohail 76dd720
reverting near_global_ocean.jl example
taimoorsohail 3177cf2
Update near_global_ocean_simulation.jl
taimoorsohail 868c870
Update Project.toml
taimoorsohail 5f02123
Added checkpointing test; integrated checkpointer into one_degree exa…
taimoorsohail f9087aa
set clock method for each simulation type
navidcy 4b0ebeb
Apply suggestions from code review
navidcy 3f0b9d5
Apply suggestions from code review
navidcy f4aa21e
don't pickup by default; add explanation
navidcy 0e0a168
merge
navidcy f56ca8e
move set_clock! for PrescribedAtmosphere to where it belongs
navidcy f8c1444
move set_clock! for PrescribedAtmosphere to where it belongs
navidcy cfba574
only pickup in the second time
navidcy 9f811df
Merge branch 'main' into ts/checkpointer-for-coupled-model
navidcy 4110aca
extend set!(model::OSIM,...) instead of set!(sim:OSIMSIM,...)
navidcy e56515f
Merge branch 'main' into ts/checkpointer-for-coupled-model
navidcy a9be97c
use default radiation
navidcy afd7a66
add set!(::PrescribedAtmospher, checkopoint_file_path)
navidcy 1fddbf2
use set!(::PrescribedAtmosphere,...)
navidcy 8699207
check all clocks are aligned
navidcy 9f9ca89
drop unused aliases
navidcy ba80b56
Merge branch 'ts/checkpointer-for-coupled-model' of github.com:CliMA/…
taimoorsohail 90abea4
Removed bottom line
taimoorsohail 9efd6b8
try to generalize
navidcy 006574f
Merge branch 'ts/checkpointer-for-coupled-model' of github.com:CliMA/…
navidcy e3029cb
Merge branch 'main' into ts/checkpointer-for-coupled-model
navidcy 1e8d638
don't assume ocean component is special
navidcy 5a69a52
bump Oceanigans compat
navidcy a74499f
remove commented code
navidcy 0a46067
properties in write_output! is kwarg
navidcy 98ec18b
undo changes
navidcy f9e9e60
Delete examples/generate_atmos_dataset.jl
navidcy 39c347a
Delete src/CoupledSimulation.jl
navidcy 5281eab
Delete test/test_ocean_sea_ice_model_parameter_space.jl
navidcy 368358e
Delete test/test_simulations.jl
navidcy 021c306
Delete src/DataWrangling/JRA55.jl
navidcy 48dd1b1
Delete src/DistributedUtils.jl
navidcy fdf45d7
don't import things we don't need
navidcy 875d045
cleanup
navidcy 1e34bb5
validate_properties -> validate_checkpointed_properties
navidcy 1f3a46b
no need to duplicate validation
navidcy 4f9425a
fix initialize! and update_state! + add set_clock!
navidcy bf96083
reorganize imports
navidcy cd7f0c5
wip
navidcy 47d1121
merge main and resolve conflicts
navidcy 8bd0d36
Update ClimaOcean.jl
navidcy ed8c6df
Merge branch 'main' into ts/checkpointer-for-coupled-model
navidcy 72efbc4
Merge branch 'main' into ts/checkpointer-for-coupled-model
taimoorsohail File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we'd like to make the checkpointer also save the clock for the atmosphere and all other models and then read it everything off from the corresponding checkpointer address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's for a future PR..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, I'm apprehensive... I hate this
because it's a hack. But on the other hand I like the symmetry here:
ClimaOcean.jl/src/OceanSeaIceModels/ocean_sea_ice_model.jl
Lines 98 to 108 in 9f9ca89
Essentially the hack tells the checkpointer for the atmosphere that it should go read data from the ocean model checkpointer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this sets the basis for future code development so in that sense is OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you have to write
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m changing that
That’s part of the hack I was explaining yesterday I don’t like.