-
Notifications
You must be signed in to change notification settings - Fork 21
Checkpointer implementation for the coupled simulation #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…unctionality for ocean model
… into checkpointer
|
@taimoorsohail now I get: julia> include("checkpointer_mwe.jl")
┌ Warning: Are you totally, 100% sure that you want to build a simulation on
│
│ 144×60×40 LatitudeLongitudeGrid{Float64, Periodic, Bounded, Bounded} on CPU with 7×7×7 halo and with precomputed metrics
│
│ rather than on an ImmersedBoundaryGrid?
└ @ ClimaOcean.OceanSimulations ~/Library/CloudStorage/OneDrive-TheUniversityofMelbourne/Documents/Research/taimoor-ClimaOcean.jl/src/OceanSimulations/ocean_simulation.jl:141
[ Info: I went in your new method! |
Another way to see that is julia> using ClimaOcean
[ Info: Oceananigans will use 12 threads
julia> methods(Checkpointer)
# 3 methods for type constructor:
[1] Checkpointer(coupled_model::OceanSeaIceModel; schedule, dir, prefix, overwrite_existing, verbose, cleanup, properties)
@ ClimaOcean.OutputWriters ~/Library/CloudStorage/OneDrive-TheUniversityofMelbourne/Documents/Research/taimoor-ClimaOcean.jl/src/OutputWriters.jl:9
[2] Checkpointer(model; schedule, dir, prefix, overwrite_existing, verbose, cleanup, properties)
@ ~/.julia/packages/Oceananigans/3CoZp/src/OutputWriters/checkpointer.jl:77
[3] Checkpointer(schedule::T, dir::String, prefix::String, properties::P, overwrite_existing::Bool, verbose::Bool, cleanup::Bool) where {T, P}
@ ~/.julia/packages/Oceananigans/3CoZp/src/OutputWriters/checkpointer.jl:11which shows that now there is a method coming from ClimaOcean! |
|
Great! I am getting the same, I fixed the bug in the precompiling also. |
|
I've added an |
And starting from scratch by picking up a checkpoint: |
|
Hey @navidcy I tried to implement a time syncing with the atmosphere (see my latest commit). It isn't working but if you figure it out let me know. |
|
I think this PR might conflict with #355 |
Co-authored-by: Gregory L. Wagner <[email protected]>
|
I'm not convinced syncing the atmosphere time with the ocean is the best way to implement the checkpointer anyway, as this would need to be added for any additional components used to drive the ocean in the future. Also, I haven't yet figured out how the radiation time steps as that would also need to be synced upon picking up. |
|
Moved to #401 |
This is an attempt to implement a checkpointer for the coupled simulation. The checkpointer should checkpoint all components of the coupled model (ocean, sea ice, atmosphere, radiation) required to restart the coupled simulation.
Work in progress still with @navidcy
Potentially superseding #374.