Typo in generate_surface_fluxes.jl + add mediterranean example #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 33 33
Lines 1828 1828
=====================================
Misses 1828 1828 ☔ View full report in Codecov by Sentry. |
navidcy
approved these changes
Nov 13, 2024
|
hm... is this parameter space shenanigans? |
|
Uff, yeah it does look like it. |
|
This PR https://github.com/CliMA/Oceananigans.jl/pull/3924/files should fix the issue I hope |
…ean.jl into ss/typo-in-generate-fluxes
|
I have added the manifest here just to point to oceananigans' branch to see if the issue persists. |
|
stale? still going? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.