Remove unused didDismiss() from InAppFCManager SDK-3591

[piyush-kukadiya]

Removes unused didDismiss() from InAppFCManager.
Before didDismiss() became NO-OP, it was used for tracking in-apps shown in a session.

        final Object id = inapp.getId();
        if (id != null) {
            mDismissedThisSession.add(id.toString());
        }
    }

However later on we replaced this entire logic with ImpressionManager class and didDismiss() kept as a NO-OP.

Summary by CodeRabbit

• Refactor
  • Streamlined the in-app notification dismissal process by removing unnecessary processing steps while maintaining the logging of dismissal events.

[coderabbitai]

Walkthrough

This change removes a no-operation method didDismiss(CTInAppNotification) from the InAppFCManager class and deletes the corresponding invocation in the InAppController class. The removal means that when an in-app notification is dismissed, the FCManager is no longer notified. Logging of the dismissal event in the controller remains unchanged, while other parts of the code retain their original behavior.

Changes

File	Changes Summary
clevertap-core/.../sdk/InAppFCManager.java	Removed the public void didDismiss(CTInAppNotification inapp) method from the class.
clevertap-core/.../sdk/inapp/InAppController.java	Deleted the call to controllerManager.getInAppFCManager().didDismiss(inAppNotification) within the inAppNotificationDidDismiss method.

Sequence Diagram(s)

Old Dismissal Flow

sequenceDiagram
    participant U as User
    participant IC as InAppController
    participant IM as InAppFCManager

    U->>IC: Dismiss in-app notification
    IC->>IM: didDismiss(inAppNotification)
    IM-->>IC: No-operation response
    IC->>IC: Log dismissal event

Loading

New Dismissal Flow

sequenceDiagram
    participant U as User
    participant IC as InAppController

    U->>IC: Dismiss in-app notification
    IC->>IC: Log dismissal event (didDismiss call removed)

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a4fcc5 and 124414c.

📒 Files selected for processing (2)

• clevertap-core/src/main/java/com/clevertap/android/sdk/InAppFCManager.java (0 hunks)
• clevertap-core/src/main/java/com/clevertap/android/sdk/inapp/InAppController.java (0 hunks)

💤 Files with no reviewable changes (2)

• clevertap-core/src/main/java/com/clevertap/android/sdk/inapp/InAppController.java
• clevertap-core/src/main/java/com/clevertap/android/sdk/InAppFCManager.java

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[darshanclevertap]

@piyush-kukadiya please provide a description for the PR