task(SDK-3620) - Upgrades AGP to 8.2.1 #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The missing classes error for exoplayer and glide has been addressed as they pertain to optional dependencies in the clevertap-sdk. 
|
CTLalit
reviewed
Feb 9, 2024
CTLalit
reviewed
Feb 9, 2024
CTLalit
reviewed
Feb 9, 2024
CTLalit
reviewed
Feb 9, 2024
sample/build.gradle
Outdated
| @@ -142,7 +142,7 @@ dependencies { | |||
| remoteImplementation("com.clevertap.android:clevertap-geofence-sdk:1.2.0") | |||
| remoteImplementation("com.clevertap.android:clevertap-xiaomi-sdk:1.5.2") | |||
| remoteImplementation("com.clevertap.android:push-templates:1.1.0") | |||
| remoteImplementation("com.clevertap.android:clevertap-hms-sdk:1.3.2") | |||
| remoteImplementation("com.clevertap.android:clevertap-hms-sdk:1.3.3") | |||
|
|
|||
| stagingImplementation("com.clevertap.android:clevertap-android-sdk:5.2.1") | |||
There was a problem hiding this comment.
Yess. All the sample app changes can be updated in a separated pr? I shall revert this for now
CTLalit
reviewed
Feb 9, 2024
CTLalit
approved these changes
Feb 10, 2024
# Conflicts: # clevertap-core/src/main/AndroidManifest.xml # gradle/libs.versions.toml # sample/build.gradle # test_shared/build.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wizrocket.atlassian.net/browse/SDK-3620
Upgrades to AGP 8 and addresses build issues because of missing classes when minify is enabled