rustfmt source code and GitHub action #48
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpmachado
force-pushed
the
feature/rustfmt-source-and-github-action
branch
from
176243a to
571a740
Compare
|
It had a bug, sorry, now all good: https://github.com/cpmachado/ultimate_rust_crash_course/actions/runs/13610721051/job/38047520433 |
|
As I go along I'd be interested in doing some testing for exercises. I've noticed it isn't covered by the current course, but when I get to next one, would you be against the idea of adding some tests for this? |
|
I'm so glad you loved my crash course! Apologies for the delay in my response. Life has been crazy for me this year. Unfortunately, there are a lot of conflicts with the comprehensive update I made and your proposed changes, so I'm going to close this pull request. Using rustfmt and clippy are both great practices that I highly recommend for real code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before anything, I'm sorry for #47 and #46 , they were mistakes.
On something useful, I'm suggesting, as referred on HowToLearnRust.md:66, to use rustfmt.
I like tooling and rules to follow, and the means to follow them.
As part of my apology, I wrote this github action largely adapted from : https://github.com/actions-rust-lang/setup-rust-toolchain
On another note, I'm loving your crash course and will recommend. I'm in the middle, but loved to discover clippy, which was referenced in one of the exercises.
Best regards,
cpmachado