Add a step to check if patches apply before invoking TuxSuite #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanchance
requested review from
nickdesaulniers,
JustinStitt and
bwendling
as code owners
JustinStitt
approved these changes
Jan 21, 2025
| with TemporaryDirectory() as workdir: | ||
| # Fetch the tarball from the repository. This is different for each type of | ||
| # tree that we support. | ||
| if args.repo.startswith( |
There was a problem hiding this comment.
Looks like a good spot for Python's new-ish match expression. I'm always looking for an excuse to use it.
Not a blocker for approval though.
There was a problem hiding this comment.
Oh wow TIL, that kind of melts my brain a little bit haha. We have technically written these scripts to be compatible with Python 3.8 and newer but it looks like match was added in 3.10? We can likely change that when ubuntu-latest becomes ubuntu-24.04 since that should have a pretty recent Python version. Thanks for the review! I will rebase this and merge it shortly.
There is no point in spinning up TuxSuite for a build if any patches that we need to apply are going to fail to do so. At the beginning of a build, check if the patches apply to the current repository and reference. This is done by downloading a tarball of the source, running 'git init' and committing the files, then finally running 'git quiltimport' to make sure that that patches still apply. It would be simpler to use 'git clone --depth=1' but cloning can be expensive on the server side and these jobs may run at the same time. Closes: ClangBuiltLinux#796 Signed-off-by: Nathan Chancellor <[email protected]>
Signed-off-by: Nathan Chancellor <[email protected]>
nathanchance
force-pushed
the
check-if-patches-apply
branch
from
c45868e to
bb5f5b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no point in spinning up TuxSuite for a build if any patches that we need to apply are going to fail to do so. At the beginning of a build, check if the patches apply to the current repository and reference. This is done by downloading a tarball of the source, running
git initand committing the files, then finally runninggit quiltimportto make sure that that patches still apply. It would be simpler to usegit clone --depth=1but cloning can be expensive on the server side and these jobs may run at the same time.Closes: #796
NOTE: I have not bumped the generated files to make this easier to review and reason through. I will do it before merging.