Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore adding a check that patches apply at current revision before calling tuxsuite #796

Open
nathanchance opened this issue Dec 16, 2024 · 0 comments · May be fixed by #800
Open

Explore adding a check that patches apply at current revision before calling tuxsuite #796

nathanchance opened this issue Dec 16, 2024 · 0 comments · May be fixed by #800

Comments

@nathanchance
Copy link
Member

Now that we have a step that runs before tuxsuite (check_cache), we should explore adding another step that checks that any patches we need to apply for that build will apply cleanly. This would make patch application failures appear more obvious and avoid blowing up tuxsuite.

nathanchance added a commit to nathanchance/continuous-integration2 that referenced this issue Jan 2, 2025
There is no point in spinning up TuxSuite for a build if any patches
that we need to apply are going to fail to do so. At the beginning of a
build, check if the patches apply to the current repository and
reference. This is done by downloading a tarball of the source, running
'git init' and committing the files, then finally running
'git quiltimport' to make sure that that patches still apply. It would
be simpler to use 'git clone --depth=1' but cloning can be expensive
on the server side and these jobs may run at the same time.

Closes: ClangBuiltLinux#796
Signed-off-by: Nathan Chancellor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant