CI: introduce a composite workflow for docker image handling #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a composite action that abstracts out the login and pushing of the container image. This allows us to uniformly perform the action without having to recheck conditions in between steps, which may drift apart.
|
@nathanchance - I think that with this, we should be able to still use the matrix strategy and build multiple architectures, though we would need to modify the tags. |
There was a problem hiding this comment.
Nice! I wired this up for the container build as well and it appears to work quite well:
https://github.com/nathanchance/containers/actions/runs/2402489607
|
LGTM with @nathanchance 's thoughts addressed. Thanks for the patch! |
This is necessary for run commands in composite actions: https://stackoverflow.com/questions/71041836/github-actions-required-property-is-missing-shell Signed-off-by: Nathan Chancellor <[email protected]>
This is slightly more descriptive. Signed-off-by: Nathan Chancellor <[email protected]>
Otherwise, the step will just show ./.github/actions/push-container which is not terribly descriptive. While we're here, use only one blank line between this step and the previous one, rather than two. Signed-off-by: Nathan Chancellor <[email protected]>
To pick up '.github/workflows/llvm-project-epoch-three.yml', which needs the same changes in this branch. Signed-off-by: Nathan Chancellor <[email protected]>
Signed-off-by: Nathan Chancellor <[email protected]>
|
I addressed my own comments and applied the changes to the epoch three workflow, hopefully you don't mind. |
nickdesaulniers
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a composite action that abstracts out the login and pushing of
the container image. This allows us to uniformly perform the action
without having to recheck conditions in between steps, which may drift
apart.