feat: add SNFI volume prediction module with compressed RDA coefficients and automatic fallback - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the SNFI tree volume prediction module for the
silviculturepackage, satisfying the requirements of PR 5.Key additions:
.rdadata files, compressed using.xzto optimize disk footprint (~380 KB).scripts/regenerate_volume_models.Rto provide a reproducible compilation pipeline from source data.silv_predict_snfi_volume(), which accepts vectors of species, provinces, DBH, height, and qualities and returns a consistent dataframe containing the four volume components (vcc,vsc,iavc,vle). It automatically falls back to SNFI3 parameters for provinces that do not have SNFI4 equations.silv_snfi_provinces()andsilv_snfi_species()to allow users to inspect available parameters directly in memory.tests/testthat/test-predict-snfi-volume.Rexecuting comprehensive combination checks (covering species, quality levels, and province lookup pathways).Verification