feat: Multipart request support #1548

ranjeetchouhan · 2026-01-08T16:14:32Z

Fixes lack of multipart support.
Fixes RequestBody.create deprecation warning.
Fixes various lint warnings.

… type.

cortinico · 2026-01-09T00:03:39Z

sample/src/main/kotlin/com/chuckerteam/chucker/sample/HttpBinHttpTask.kt

+            val body = "This is a body".toRequestBody("text/plain".toMediaType())
+            multipart("Value 1", body).enqueue(noOpCallback)


Suggested change

val body = "This is a body".toRequestBody("text/plain".toMediaType())

multipart("Value 1", body).enqueue(noOpCallback)

val value2RequestBody = "This is a body".toRequestBody("text/plain".toMediaType())

multipart(value1 = "value1", value2 = value2RequestBody).enqueue(noOpCallback)

cortinico · 2026-01-09T00:04:23Z

...in/com/chuckerteam/chucker/internal/data/repository/HttpTransactionDatabaseRepositoryTest.kt

            testObject.insertTransaction(transactionThree)
            testObject.insertTransaction(transactionFour)
            testObject.getFilteredTransactionTuples(code = "", path = "").observeForever { result ->
-                assertTuples(listOf(transactionFour, transactionThree, transactionOne, transactionTwo), result)


Can you send this + all the other related changes as a separate PR please?

cortinico · 2026-01-09T00:05:07Z

library/src/test/kotlin/com/chuckerteam/chucker/api/ChuckerInterceptorMultipartTest.kt

+
+        val transaction = chuckerInterceptor.expectTransaction()
+
+        // This assertion is what we WANT to see after the fix.


cortinico · 2026-01-09T00:05:29Z

library/src/main/kotlin/com/chuckerteam/chucker/internal/ui/transaction/TransactionActivity.kt

    override fun onOptionsItemSelected(item: MenuItem) =
        when (item.itemId) {
-            R.id.share_text ->
+            R.id.share_text -> {


please send those changes in a separate PR

cortinico · 2026-01-09T00:06:25Z

library/src/main/kotlin/com/chuckerteam/chucker/internal/data/entity/HttpTransactionTuple.kt

    @ColumnInfo(name = "error") var error: String?,
    @ColumnInfo(name = "graphQlDetected") var graphQlDetected: Boolean = false,
    @ColumnInfo(name = "graphQlOperationName") var graphQlOperationName: String?,
+    @ColumnInfo(name = "requestContentType") var requestContentType: String?,


we need to bump the DB version because of this

cortinico · 2026-01-09T00:09:13Z

library/src/main/kotlin/com/chuckerteam/chucker/internal/support/RequestProcessor.kt

+        return buildString {
+            body.parts.forEach { part ->
+                part.headers?.forEach { header ->
+                    append(header.first + ": " + header.second + "\n")


can you string interpolate here?

Copilot

Pull request overview

This PR adds multipart request body support to Chucker, allowing proper inspection and formatting of multipart/form-data requests. It also addresses deprecation warnings and various lint issues.

Key changes:

Adds multipart request body processing with intelligent plain text vs. binary detection
Extends transaction filtering to support searching by request content type
Updates test utilities and adds comprehensive multipart test coverage

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
library/src/main/kotlin/com/chuckerteam/chucker/internal/support/RequestProcessor.kt	Adds processMultipartPayload method to format multipart bodies with headers and content, includes isPlainText helper
library/src/main/kotlin/com/chuckerteam/chucker/internal/data/room/HttpTransactionDao.kt	Updates database queries to include requestContentType field in tuple selection and filtering
library/src/main/kotlin/com/chuckerteam/chucker/internal/data/repository/HttpTransactionDatabaseRepository.kt	Passes contentTypeQuery parameter to enable filtering by request content type
library/src/main/kotlin/com/chuckerteam/chucker/internal/data/entity/HttpTransactionTuple.kt	Adds requestContentType field to tuple for efficient filtering
library/src/test/kotlin/com/chuckerteam/chucker/api/ChuckerInterceptorMultipartTest.kt	New test file validating multipart body formatting with text and binary parts
library/src/test/kotlin/com/chuckerteam/chucker/internal/data/repository/HttpTransactionDatabaseRepositoryTest.kt	Adds test for filtering transactions by requestContentType, fixes formatting
library/src/test/kotlin/com/chuckerteam/chucker/internal/data/entity/TransactionTestUtils.kt	Updates assertion helper to verify requestContentType field
library/src/test/kotlin/com/chuckerteam/chucker/internal/data/entity/HttpTransactionTupleTest.kt	Adds requestContentType parameter to test helper method
library/src/main/kotlin/com/chuckerteam/chucker/internal/ui/transaction/TransactionActivity.kt	Adds braces to when expression branches for lint compliance
sample/src/main/kotlin/com/chuckerteam/chucker/sample/HttpBinHttpTask.kt	Adds multipart endpoint demonstration using non-deprecated toRequestBody extension

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-09T00:15:23Z

library/src/main/kotlin/com/chuckerteam/chucker/internal/support/RequestProcessor.kt

+    @Suppress("TooGenericExceptionCaught", "SwallowedException")
+    private fun isPlainText(buffer: Buffer): Boolean {
+        try {
+            val prefix = Buffer()
+            val byteCount = if (buffer.size < MAX_PREFIX_LENGTH) buffer.size else MAX_PREFIX_LENGTH
+            buffer.copyTo(prefix, 0, byteCount)
+            repeat(MAX_CODEPOINTS_TO_CHECK) {
+                if (prefix.exhausted()) {
+                    return@repeat
+                }
+                val codePoint = prefix.readUtf8CodePoint()
+                if (Character.isISOControl(codePoint) && !Character.isWhitespace(codePoint)) {
+                    return false
+                }
+            }
+            return true
+        } catch (e: Exception) {
+            return false
+        }
+    }


The isPlainText method duplicates existing functionality. The codebase already has a Buffer.isProbablyPlainText extension property in OkioUtils.kt that does the same thing. Consider using the existing utility instead of creating a duplicate implementation. This would reduce code duplication and ensure consistent behavior across the codebase.

Copilot · 2026-01-09T00:15:23Z

library/src/main/kotlin/com/chuckerteam/chucker/internal/support/RequestProcessor.kt

+    private companion object {
+        const val MAX_PREFIX_LENGTH = 64L
+        const val MAX_CODEPOINTS_TO_CHECK = 16
+    }


The constants MAX_PREFIX_LENGTH and MAX_CODEPOINTS_TO_CHECK differ from the existing implementation in OkioUtils.kt (which uses MAX_PREFIX_SIZE = 64L and CODE_POINT_SIZE = 16). While the values are the same, using different constant names can cause confusion. If you switch to using Buffer.isProbablyPlainText as suggested, this inconsistency would be resolved.

Copilot · 2026-01-09T00:15:23Z

library/src/main/kotlin/com/chuckerteam/chucker/internal/support/RequestProcessor.kt

+                }
+
+                val buffer = Buffer()
+                partBody.writeTo(buffer)


The call to partBody.writeTo(buffer) could throw an IOException but is not wrapped in a try-catch block. If this fails, the entire multipart processing would fail and potentially crash. Consider adding error handling similar to how it's done in processPayload for regular request bodies (lines 76-82).

Suggested change

partBody.writeTo(buffer)

try {

partBody.writeTo(buffer)

} catch (e: IOException) {

Logger.error("Failed to read multipart request payload", e)

append(context.getString(R.string.chucker_body_content_truncated))

return@buildString

}

Copilot · 2026-01-09T00:15:23Z

library/src/test/kotlin/com/chuckerteam/chucker/api/ChuckerInterceptorMultipartTest.kt

+    @ParameterizedTest
+    @EnumSource(value = ClientFactory::class)
+    fun `multipart body is formatted correctly`(factory: ClientFactory) {
+        val chuckerInterceptor =
+            ChuckerInterceptorDelegate(
+                cacheDirectoryProvider = { tempDir },
+            )
+        val client = factory.create(chuckerInterceptor)
+
+        val binaryData = byteArrayOf(0x00, 0x01, 0x02, 0x03)
+        val multipartBody =
+            MultipartBody
+                .Builder()
+                .setType(MultipartBody.FORM)
+                .addFormDataPart("title", "Square Logo")
+                .addFormDataPart(
+                    "image",
+                    "logo.png",
+                    binaryData.toRequestBody("image/png".toMediaType()),
+                ).build()
+
+        val request =
+            Request
+                .Builder()
+                .url(serverUrl)
+                .post(multipartBody)
+                .build()
+        server.enqueue(MockResponse().setBody("OK"))
+
+        client.newCall(request).execute().readByteStringBody()
+
+        val transaction = chuckerInterceptor.expectTransaction()
+
+        // This assertion is what we WANT to see after the fix.
+        // Current behavior will likely fail this.
+        assertThat(transaction.requestBody).contains("Content-Disposition: form-data; name=\"title\"")
+        assertThat(transaction.requestBody).contains("Square Logo")
+        assertThat(transaction.requestBody).contains("Content-Disposition: form-data; name=\"image\"")
+        assertThat(transaction.requestBody).contains("filename=\"logo.png\"")
+        assertThat(transaction.requestBody).contains("Content-Type: image/png")
+        // Binary content should be replaced with placeholder
+        assertThat(transaction.requestBody).contains("(binary: 4 bytes)")
+    }


The test doesn't cover the case where multipart content exceeds maxContentLength. Consider adding a test case that validates the truncation behavior (line 121-123 in RequestProcessor.kt) works correctly for multipart bodies, similar to how it's tested for regular request bodies in ChuckerInterceptorTest.

Copilot · 2026-01-09T00:15:24Z

library/src/main/kotlin/com/chuckerteam/chucker/internal/support/RequestProcessor.kt

+    private fun processMultipartPayload(body: MultipartBody): String {
+        return buildString {
+            body.parts.forEach { part ->
+                part.headers?.forEach { header ->
+                    append(header.first + ": " + header.second + "\n")
+                }
+                val partBody = part.body
+                if (partBody.contentType() != null) {
+                    append("Content-Type: ${partBody.contentType()}\n")
+                }
+                if (partBody.contentLength() != -1L) {
+                    append("Content-Length: ${partBody.contentLength()}\n")
+                }
+
+                val buffer = Buffer()
+                partBody.writeTo(buffer)
+
+                if (isPlainText(buffer)) {
+                    append("\n")
+                    append(buffer.readUtf8())
+                } else {
+                    append("\n(binary: ${partBody.contentLength()} bytes)")
+                }
+                append("\n\n")


Each multipart part's body is fully read into memory before checking against maxContentLength. For very large plain text parts, this could cause memory issues. Consider checking the accumulated length before reading each part, or implementing a streaming approach similar to how regular request bodies are handled with LimitingSource.

ranjeetchouhan added 2 commits January 8, 2026 21:01

feat: Display multipart request bodies and allow filtering by content…

821547d

… type.

refactor: use block bodies for when statements

d6f54b6

ranjeetchouhan requested a review from a team as a code owner January 8, 2026 16:14

ranjeetchouhan changed the title ~~fix: Multipart request support~~ feat: Multipart request support Jan 8, 2026

cortinico reviewed Jan 9, 2026

View reviewed changes

cortinico requested a review from Copilot January 9, 2026 00:10

Copilot started reviewing on behalf of cortinico January 9, 2026 00:10 View session

Copilot AI reviewed Jan 9, 2026

View reviewed changes

		val body = "This is a body".toRequestBody("text/plain".toMediaType())
		multipart("Value 1", body).enqueue(noOpCallback)


		val transaction = chuckerInterceptor.expectTransaction()

		// This assertion is what we WANT to see after the fix.

-                partBody.writeTo(buffer)
+                try {
+                    partBody.writeTo(buffer)
+                } catch (e: IOException) {
+                    Logger.error("Failed to read multipart request payload", e)
+                    append(context.getString(R.string.chucker_body_content_truncated))
+                    return@buildString
+                }

Uh oh!

feat: Multipart request support #1548

Are you sure you want to change the base?

feat: Multipart request support #1548

Uh oh!

Conversation

ranjeetchouhan commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cortinico Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

cortinico Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

cortinico Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

cortinico Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

cortinico Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

cortinico Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ranjeetchouhan commented Jan 8, 2026 •

edited

Loading