Skip to content

Commit

Permalink
Update security panel unknown icon to match latest approved mocks
Browse files Browse the repository at this point in the history
Before: https://screenshot.googleplex.com/7BvEtNjLcHwcEee.png
After: https://screenshot.googleplex.com/5VzsLygAegLGyir.png
Mock: https://screenshot.googleplex.com/79FJBf3nrVzcJN3.png

Bug: b/391851519
Change-Id: Idd1c18a54ea2685c6c0d2a4efc66b823c3ae5de6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6193258
Commit-Queue: Joshua Thomas <[email protected]>
Reviewed-by: Danil Somsikov <[email protected]>
Reviewed-by: Shuran Huang <[email protected]>
  • Loading branch information
masnoble authored and Devtools-frontend LUCI CQ committed Jan 23, 2025
1 parent dc10dec commit 277a5f5
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions front_end/panels/security/SecurityPanel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ const SignatureSchemeStrings = new Map([

const LOCK_ICON_NAME = 'lock';
const WARNING_ICON_NAME = 'warning';
const INFO_ICON_NAME = 'info';
const UNKNOWN_ICON_NAME = 'indeterminate-question-box';

export function getSecurityStateIconForDetailedView(
securityState: Protocol.Security.SecurityState, className: string): IconButton.Icon.Icon {
Expand All @@ -483,7 +483,7 @@ export function getSecurityStateIconForDetailedView(
break;
case Protocol.Security.SecurityState.Info: // fallthrough
case Protocol.Security.SecurityState.Unknown:
iconName = INFO_ICON_NAME;
iconName = UNKNOWN_ICON_NAME;
break;
}

Expand All @@ -496,7 +496,7 @@ export function getSecurityStateIconForOverview(
switch (securityState) {
case Protocol.Security.SecurityState.Unknown: // fallthrough
case Protocol.Security.SecurityState.Neutral:
iconName = INFO_ICON_NAME;
iconName = UNKNOWN_ICON_NAME;
break;
case Protocol.Security.SecurityState.Insecure: // fallthrough
case Protocol.Security.SecurityState.InsecureBroken:
Expand Down

0 comments on commit 277a5f5

Please sign in to comment.