feat: export console issues #505
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
reviewed
Oct 31, 2025
OrKoN
reviewed
Oct 31, 2025
| BUILD_DIR, | ||
| 'node_modules/chrome-devtools-frontend/front_end/models/issues_manager/descriptions', | ||
| ); | ||
| fs.cpSync(sourceDir, destDir, {recursive: true}); |
There was a problem hiding this comment.
is the destDir the same as sourceDir?
OrKoN
reviewed
Oct 31, 2025
| import * as path from 'node:path'; | ||
|
|
||
| const DESCRIPTIONS_PATH = path.join( | ||
| process.cwd(), |
There was a problem hiding this comment.
we should not use the process.cwd() because the server could be start from any current working directory. Instead let's use import.meta.dirname
OrKoN
reviewed
Oct 31, 2025
| } | ||
|
|
||
| protected async subscribeForIssues(page: Page) { | ||
| if (this instanceof NetworkCollector) { |
There was a problem hiding this comment.
Let's create a subclass for ConsoleCollector and invoke this by extending the addPage call. Let's also make sure we set up listeners first (by calling this.#initializePage) and then call subscribeForIssues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.