Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stacked] support ledger cosmos signing in staking-cli #26

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

mkaczanowski
Copy link
Contributor

TL;DR

This PR:

  1. fixes the ledger cosmos signing - the newest app is no longer compatible with the official ledgerhq lib, instead I had to switch to the repo maintained by the author of the ledger hw app
  2. added support for signer-ledger-cosmos to staking-cli
  3. Fixed the issue when the public key is not returned by LCD (doesn't have to be)

Test plan

$ npm run staking-cli -- cosmos tx delegate 0.15 -c ./config.testnet.json -s ledger -b
Check TX status here: https://testnet.celestia.explorers.guru/transaction/7EB07E30FAEF5AAB3F9E1283CCE24F553B795342A875357B27C8A504AC3D19BC

@mkaczanowski mkaczanowski force-pushed the add_ledger_ton_support branch from a7cd459 to 0ed2724 Compare February 24, 2025 11:51
@mkaczanowski mkaczanowski changed the base branch from add_ledger_ton_support to main February 24, 2025 12:08
@mkaczanowski mkaczanowski force-pushed the update_cosmos_ledger_signing branch from 8a5c411 to b12285b Compare February 24, 2025 12:08
Copy link
Collaborator

@welldan97 welldan97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mkaczanowski mkaczanowski merged commit e60976c into main Feb 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants