-
-
Notifications
You must be signed in to change notification settings - Fork 778
Allow for IDocumentStore to provide document hash. #8228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for IDocumentStore to provide document hash. #8228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/HotChocolate/Language/src/Language.Web/CachedDocument.cs:8
- [nitpick] Consider renaming 'hash' to 'documentHash' in the constructor for added clarity about its purpose.
string? hash,
src/HotChocolate/Core/src/Execution/Pipeline/ReadPersistedOperationMiddleware.cs:91
- Consider specifying a StringComparison (or using an invariant/case-sensitive comparison) for the algorithm name and format checks to avoid potential mismatches due to case differences.
if (document is IOperationDocumentHashProvider hashProvider && _documentHashAlgorithm.Name.Equals(hashProvider.Hash.AlgorithmName) && _documentHashAlgorithm.Format.Equals(hashProvider.Hash.Format))
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8228 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.