Skip to content

Allow for IDocumentStore to provide document hash. #8228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025

Conversation

michaelstaib
Copy link
Member

No description provided.

@michaelstaib michaelstaib self-assigned this Apr 3, 2025
@michaelstaib michaelstaib added this to the HC-15.1.4 milestone Apr 3, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

@michaelstaib michaelstaib added the 🍒 cherry-pick Consider cherry-picking these changes into the previous major version. label Apr 3, 2025
@michaelstaib michaelstaib requested a review from Copilot April 4, 2025 06:57
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/HotChocolate/Language/src/Language.Web/CachedDocument.cs:8

  • [nitpick] Consider renaming 'hash' to 'documentHash' in the constructor for added clarity about its purpose.
string? hash,

src/HotChocolate/Core/src/Execution/Pipeline/ReadPersistedOperationMiddleware.cs:91

  • Consider specifying a StringComparison (or using an invariant/case-sensitive comparison) for the algorithm name and format checks to avoid potential mismatches due to case differences.
if (document is IOperationDocumentHashProvider hashProvider && _documentHashAlgorithm.Name.Equals(hashProvider.Hash.AlgorithmName) && _documentHashAlgorithm.Format.Equals(hashProvider.Hash.Format))

@michaelstaib michaelstaib merged commit 86773a7 into main Apr 4, 2025
104 checks passed
@michaelstaib michaelstaib deleted the mst/allow-for-document-store-to-provide-hash branch April 4, 2025 07:08
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (2abdde9) to head (a21b306).
Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #8228   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 cherry-pick Consider cherry-picking these changes into the previous major version. 🌶️ hot chocolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant