Skip to content

Conversation

@richardkiss
Copy link
Contributor

@richardkiss richardkiss commented Apr 2, 2025

There should be no semantic changes here, just formatting. And renaming one variable because ruff check doesn't like l (l) as a variable name. And with this sans-serif font here, we see why: it looks like a one.

@richardkiss richardkiss requested review from altendky and Copilot April 2, 2025 20:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR applies formatting changes and fixes identified by ruff, improving consistency across the codebase. Key changes include:

  • Adjusting whitespace and line breaks in test files and core modules.
  • Standardizing string literal quoting (switching from single to double quotes) and hexadecimal literal casing.
  • Reformating error messages and tuple unpacking for improved clarity.

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/to_sexp_test.py Removed extraneous blank lines and reformatted assertions.
tests/serialize_test.py Standardized byte-string quotes and adjusted multi-line print formatting.
tests/run_program_test.py Updated hex literal case and removed unnecessary blank lines.
tests/operators_test.py Reformatted lambda expressions and standardized quotes.
tests/cmds_test.py Reformatted the entry_points call for clarity.
clvm/run_program.py Removed blank lines and added a trailing comma.
clvm/operators.py Improved import grouping and simplified protocol definitions.
clvm/more_ops.py Reformatted error raises and clarified tuple unpacking.
clvm/as_python.py Reformatted union type definitions for clarity.
clvm/SExp.py Reformatted union type and added spacing for readability.
clvm/CLVMObject.py Reformatted ValueError message to a multi-line format.

@coveralls-official
Copy link

coveralls-official bot commented Apr 2, 2025

Pull Request Test Coverage Report for Build 14229065199

Details

  • 18 of 19 (94.74%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 94.142%

Changes Missing Coverage Covered Lines Changed/Added Lines %
clvm/CLVMObject.py 0 1 0.0%
Totals Coverage Status
Change from base Build 14228689936: 0.01%
Covered Lines: 1203
Relevant Lines: 1258

💛 - Coveralls

@richardkiss richardkiss merged commit df4695f into main Apr 2, 2025
21 checks passed
@richardkiss richardkiss deleted the ruff-mypy branch April 2, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants