[LABS-299] Extract pool wallet pubkey generation to WSM #20322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
changed the title
Quexington
added
the
Changed
Base automatically changed from
quex.port_create_new_wallet_to_marshal
to
main
December 8, 2025 17:31
github-actions
bot
added
the
merge_conflict
Quexington
force-pushed
the
quex.extract_pool_pubkey_to_wsm
branch
from
191874a to
4e6324a
Compare
github-actions
bot
removed
the
merge_conflict
prozacchiwawa
approved these changes
Dec 8, 2025
Contributor
prozacchiwawa
left a comment
prozacchiwawa
left a comment
There was a problem hiding this comment.
makes sense. verified that the formerly copied path matches the one in master_sk_to_singleton_owner_sk.
Contributor
|
cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
|
markelrod
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves a small chunk of code out of the RPC.
Note
Extracts pool wallet owner pubkey generation into
WalletStateManager.new_pool_wallet_pubkey()and updates pool wallet creation RPC to use it.new_pool_wallet_pubkey()to derive deterministic pool wallet owner pubkeys withMAX_POOL_WALLETSguard usingmaster_sk_to_singleton_owner_sk.MAX_POOL_WALLETSandmaster_sk_to_singleton_owner_sk.wallet_rpc_api.py):CreateNewWallet(POOL_WALLET,NEW): replace inline owner pubkey derivation and limits logic withwallet_state_manager.new_pool_wallet_pubkey(); pass inlineawait action_scope.get_puzzle_hash(...)toinitial_pool_state_from_dict.initial_pool_state_from_dictfromchia.pools.pool_wallet_info.Written by Cursor Bugbot for commit 4e6324a. This will update automatically on new commits. Configure here.