[LABS-302] Forward send_transaction and cat_spend to create_signed_transaction
#20321
+88
−78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
send_transactionandcat_spendendpoints are simpler and less powerful versions of thecreate_signed_transactionendpoint. In order to reduce duplication, this PR implements the former endpoints as calls to the latter endpoint much like howsend_transaction_multiworks. We should probably deprecate all endpoints that are notcreate_signed_transactionbut that's a task for another time and day.Note
Refactors wallet RPC to route send_transaction and cat_spend through create_signed_transaction, adds shared CAT discrepancy validation, extends CreateSignedTransaction with CAT fields, tightens address validation, and updates tests.
send_transactionandcat_spendto delegate tocreate_signed_transactionusingAdditionandaction_scope_override.ensure_valid_address(forAddressType.XCH).create_signed_transaction, pass throughpuzzle_decorator_overrideandcat_discrepancyto signing.cat_discrepancy_validation()helper and use it inCATSpend.cat_discrepancy.CreateSignedTransactionwith CAT fields:extra_delta,tail_reveal,tail_solution, and addcat_discrepancyproperty.additionsand verify error handling for CAT discrepancy parameters.Written by Cursor Bugbot for commit 360afed. This will update automatically on new commits. Configure here.