Skip to content

Conversation

@Quexington
Copy link
Contributor

@Quexington Quexington commented Dec 5, 2025

The send_transaction and cat_spend endpoints are simpler and less powerful versions of the create_signed_transaction endpoint. In order to reduce duplication, this PR implements the former endpoints as calls to the latter endpoint much like how send_transaction_multi works. We should probably deprecate all endpoints that are not create_signed_transaction but that's a task for another time and day.


Note

Refactors wallet RPC to route send_transaction and cat_spend through create_signed_transaction, adds shared CAT discrepancy validation, extends CreateSignedTransaction with CAT fields, tightens address validation, and updates tests.

  • Wallet RPC:
    • Refactor send_transaction and cat_spend to delegate to create_signed_transaction using Addition and action_scope_override.
    • Enforce address checks via ensure_valid_address (for AddressType.XCH).
    • In create_signed_transaction, pass through puzzle_decorator_override and cat_discrepancy to signing.
  • Request Types:
    • Add cat_discrepancy_validation() helper and use it in CATSpend.cat_discrepancy.
    • Extend CreateSignedTransaction with CAT fields: extra_delta, tail_reveal, tail_solution, and add cat_discrepancy property.
  • Tests:
    • Update CAT spend validation cases to use non-empty additions and verify error handling for CAT discrepancy parameters.

Written by Cursor Bugbot for commit 360afed. This will update automatically on new commits. Configure here.

@Quexington Quexington requested a review from a team as a code owner December 5, 2025 16:21
@Quexington Quexington changed the title Forward send_transaction and cat_spend to create_signed_transaction [LABS-302] Forward send_transaction and cat_spend to create_signed_transaction Dec 5, 2025
@Quexington Quexington added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Dec 5, 2025
@coveralls-official
Copy link

coveralls-official bot commented Dec 5, 2025

Pull Request Test Coverage Report for Build 20103032310

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 44 of 45 (97.78%) changed or added relevant lines in 2 files are covered.
  • 432 unchanged lines in 22 files lost coverage.
  • Overall coverage increased (+0.02%) to 90.788%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/wallet/wallet_rpc_api.py 22 23 95.65%
Files with Coverage Reduction New Missed Lines %
chia/_tests/wallet/cat_wallet/test_trades.py 1 99.8%
chia/_tests/wallet/nft_wallet/test_nft_bulk_mint.py 1 99.43%
chia/timelord/timelord_api.py 1 93.02%
chia/pools/pool_wallet_info.py 2 97.73%
chia/_tests/core/test_farmer_harvester_rpc.py 2 98.06%
chia/full_node/full_node.py 3 87.0%
chia/wallet/wallet_state_manager.py 3 96.46%
chia/introducer/introducer.py 4 83.62%
chia/_tests/wallet/rpc/test_wallet_rpc.py 4 99.65%
chia/wallet/wallet_rpc_client.py 4 96.54%
Totals Coverage Status
Change from base Build 19938390251: 0.02%
Covered Lines: 102714
Relevant Lines: 112964

💛 - Coveralls

@emlowe
Copy link
Contributor

emlowe commented Dec 9, 2025

cursor review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changed Required label for PR that categorizes merge commit message as "Changed" for changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants