-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[LABS-307] Extract manual syncing logic out of wallet RPC #20318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Quexington
wants to merge
3
commits into
main
Choose a base branch
from
quex.extract_manual_syncing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+352
−318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 19967060081Details
💛 - Coveralls |
00989fa to
e631f8d
Compare
Contributor
Contributor
|
cursor review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
coverage-diff
merge_conflict
Branch has conflicts that prevent merge to main
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves a large chunk of code from the wallet RPC into WSM. None of this logic belongs in the RPC which is a front end primarily concerned with serialization and conversion of types.
Note
Extracts manual DID/NFT singleton search and DID recovery into WalletStateManager and updates RPC endpoints to delegate to these helpers, with tests adjusted accordingly.
get_latest_singleton_coin_spend(),manual_did_search(),manual_nft_search(), andfind_lost_did().ManualDIDSearchResultsandManualNFTSearchResultsdataclasses.did_get_info,did_find_lost_did, andnft_get_infonow delegate toWalletStateManagerhelpers.get_latest_singleton_coin_spendand related inline DID/NFT parsing logic; trims unused imports.nft_get_infoparsing/validation behavior (remove invalid coin-id format assertion).Written by Cursor Bugbot for commit 15270c9. This will update automatically on new commits. Configure here.