Skip to content

Conversation

@emlowe
Copy link
Contributor

@emlowe emlowe commented Oct 24, 2025

Add python 3.14 support.

Current status: Runs fine - need to fix issues with CI tests. Some problems remain

Draft For:


Note

Add Python 3.14 support across CI, install scripts, and runtime, with asyncio policy updates and dependency bumps.

  • Build/CI:
    • Add Python 3.14 to matrices in check_wheel_availability.yaml, pre-commit.yml, test-single.yml, and upload-pypi-source.yml.
    • Install scripts updated to detect/allow 3.14 (install.sh, Install.ps1).
  • Runtime/Compatibility:
    • Update ChiaPolicy to use asyncio.events._BaseDefaultEventLoopPolicy on Python >=3.14 (chia/server/chia_policy.py).
    • Fix full node long-sync cleanup: only call _finish_sync() if not shutting down (chia/full_node/full_node.py).
    • Use concrete IPv4Address/IPv6Address when storing peers (chia/seeder/dns_server.py).
  • Tests:
    • Await ws_server.stop(); improve temp file context; ensure wallet RPC client closed; add consensus mode limit marker; add pytest warning filters.
  • Dependencies:
    • Bump bitarray to 3.8.0, markupsafe to 3.0.3, zstd to 1.5.7.2, tach to >=0.32.0; refresh poetry.lock and adjust constraints in pyproject.toml.

Written by Cursor Bugbot for commit b16bc71. This will update automatically on new commits. Configure here.

@coveralls-official
Copy link

coveralls-official bot commented Oct 24, 2025

Pull Request Test Coverage Report for Build 20073345542

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 32 of 39 (82.05%) changed or added relevant lines in 12 files are covered.
  • 367 unchanged lines in 20 files lost coverage.
  • Overall coverage remained the same at 90.78%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/_tests/util/test_replace_str_to_bytes.py 4 5 80.0%
chia/server/chia_policy.py 7 13 53.85%
Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.47%
chia/_tests/wallet/nft_wallet/test_nft_bulk_mint.py 1 99.43%
chia/timelord/timelord_api.py 1 93.02%
chia/wallet/util/wallet_sync_utils.py 1 85.57%
chia/pools/pool_wallet_info.py 2 97.73%
chia/timelord/timelord_launcher.py 2 71.43%
chia/wallet/wallet_node.py 3 86.69%
chia/full_node/full_node.py 4 87.0%
chia/server/node_discovery.py 4 80.86%
chia/_tests/wallet/rpc/test_wallet_rpc.py 4 99.65%
Totals Coverage Status
Change from base Build 19971179576: 0.0%
Covered Lines: 102700
Relevant Lines: 112961

💛 - Coveralls

@emlowe emlowe added the Added Required label for PR that categorizes merge commit message as "Added" for changelog label Oct 30, 2025
@socket-security
Copy link

socket-security bot commented Nov 3, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedpypi/​bitarray@​3.0.0 ⏵ 3.8.094 +1100100100100
Updatedpypi/​tach@​0.32.0 ⏵ 0.32.199 +1100100100100
Updatedpypi/​markupsafe@​3.0.2 ⏵ 3.0.3100 +1100100100100

View full report

@emlowe
Copy link
Contributor Author

emlowe commented Dec 5, 2025

close and reopen for latest

@emlowe emlowe closed this Dec 5, 2025
@emlowe emlowe reopened this Dec 5, 2025
@socket-security
Copy link

socket-security bot commented Dec 8, 2025

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@emlowe
Copy link
Contributor Author

emlowe commented Dec 9, 2025

cursor review

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Dec 9, 2025
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Dec 9, 2025
@github-actions
Copy link
Contributor

File Coverage Missing Lines
chia/_tests/util/test_replace_str_to_bytes.py 80.0% lines 144
chia/server/chia_policy.py 53.8% lines 354-355, 357-358, 360, 362
Total Missing Coverage
43 lines 7 lines 83%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Added Required label for PR that categorizes merge commit message as "Added" for changelog coverage-diff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants