Skip to content

Conversation

@Quexington
Copy link
Contributor

@Quexington Quexington commented Oct 22, 2025

Another PR following #18593


Note

Migrates get_farmed_amount to a marshaled, typed RPC using GetFarmedAmount and GetFarmedAmountResponse, updating client/CLI usage and tests.

  • RPC/API:
    • Convert wallet_rpc_api.get_farmed_amount to @marshal with typed GetFarmedAmount -> GetFarmedAmountResponse.
    • Add new streamables: GetFarmedAmount and GetFarmedAmountResponse in wallet_request_types.py.
    • Update WalletRpcClient.get_farmed_amount to accept request object and return typed response.
  • CLI (chia/cmds/farm_funcs.py):
    • Update get_wallets_stats to use GetFarmedAmount and return GetFarmedAmountResponse.
    • Adjust summary output to use attributes instead of dict keys.
  • Tests:
    • Update wallet RPC tests to call get_farmed_amount(GetFarmedAmount()) and assert against GetFarmedAmountResponse and attributes.

Written by Cursor Bugbot for commit 824cbe6. This will update automatically on new commits. Configure here.

@Quexington Quexington requested a review from a team as a code owner October 22, 2025 18:54
@Quexington Quexington added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Oct 22, 2025
@Quexington Quexington changed the title Port get_farmed_amount to @marshal [LABS-291] Port get_farmed_amount to @marshal Oct 22, 2025
@Quexington Quexington force-pushed the quex.port_crcat_approve_pending branch from d267ad3 to 33adc84 Compare December 5, 2025 17:10
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Dec 5, 2025
@Quexington Quexington force-pushed the quex.port_get_farmed_amount_to_marshal branch from e8394ef to 445a6d0 Compare December 5, 2025 17:16
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Dec 5, 2025
@Quexington Quexington force-pushed the quex.port_crcat_approve_pending branch from 33adc84 to bd5ea50 Compare December 8, 2025 17:39
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Dec 8, 2025
Base automatically changed from quex.port_crcat_approve_pending to main December 9, 2025 21:15
@Quexington Quexington force-pushed the quex.port_get_farmed_amount_to_marshal branch from 445a6d0 to 824cbe6 Compare December 9, 2025 21:39
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Dec 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

File Coverage Missing Lines
chia/cmds/farm_funcs.py 81.8% lines 136-137
Total Missing Coverage
35 lines 2 lines 94%

@coveralls-official
Copy link

Pull Request Test Coverage Report for Build 20079371249

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 33 of 35 (94.29%) changed or added relevant lines in 5 files are covered.
  • 53 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.03%) to 90.796%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/cmds/farm_funcs.py 9 11 81.82%
Files with Coverage Reduction New Missed Lines %
chia/full_node/full_node.py 1 87.14%
chia/_tests/simulation/test_simulation.py 1 96.47%
chia/wallet/wallet_node.py 1 86.69%
chia/timelord/timelord_launcher.py 2 71.43%
chia/server/server.py 4 84.99%
chia/introducer/introducer_api.py 5 81.48%
chia/server/node_discovery.py 5 80.5%
chia/timelord/timelord.py 12 71.68%
chia/_tests/core/util/test_lockfile.py 22 77.42%
Totals Coverage Status
Change from base Build 20078789497: -0.03%
Covered Lines: 102750
Relevant Lines: 112995

💛 - Coveralls

@TheLastCicada TheLastCicada merged commit 88e9f78 into main Dec 10, 2025
410 of 412 checks passed
@TheLastCicada TheLastCicada deleted the quex.port_get_farmed_amount_to_marshal branch December 10, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changed Required label for PR that categorizes merge commit message as "Changed" for changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants