Skip to content

[CHIA-3391] Port test_nft*offers.py to be parametrized with R-CATs #19842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Quexington
Copy link
Contributor

@Quexington Quexington commented Jul 17, 2025

Another PR increasing R-CAT test coverage.

No production code changes as a result of this port.

There was one small change needed to the most complex test due to the different minting method resulting in a later exact change scenario which messed with a few of the balance calculations.

@Quexington Quexington requested a review from a team as a code owner July 17, 2025 09:38
@Quexington Quexington added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Tests Changes to tests labels Jul 17, 2025
Copy link

Pull Request Test Coverage Report for Build 16342506293

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 44 of 44 (100.0%) changed or added relevant lines in 2 files are covered.
  • 14 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.02%) to 91.393%

Files with Coverage Reduction New Missed Lines %
chia/daemon/client.py 1 74.72%
chia/full_node/pending_tx_cache.py 1 96.55%
chia/wallet/wallet_node.py 1 87.45%
chia/server/node_discovery.py 2 82.11%
chia/_tests/core/util/test_lockfile.py 2 90.28%
chia/full_node/full_node.py 7 88.33%
Totals Coverage Status
Change from base Build 16332491766: 0.02%
Covered Lines: 102409
Relevant Lines: 111941

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Tests Changes to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant