cat_wallet mypy fixes #12998
Merged
cat_wallet mypy fixes #12998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-o-how
previously approved these changes
Aug 16, 2022
mariano54
previously approved these changes
Aug 16, 2022
altendky
suggested changes
Aug 16, 2022
arvidn
force-pushed
the
cat-wallet-mypy
branch
from
e4dd4d7 to
f243136
Compare
Co-authored-by: Kyle Altendorf <[email protected]>
arvidn
force-pushed
the
cat-wallet-mypy
branch
from
f243136 to
d27b956
Compare
altendky
approved these changes
Aug 16, 2022
mariano54
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the mypy exceptions for the cat wallet files (but not the tests) and fixes type annotations