Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

positive and negative relu activation function 'linear' operators #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jkwashbourne
Copy link
Contributor

The JopReluMin and JopReluMax tests rely on change to Jets allowing specifying vectors to linearity_test

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2021

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (dbff81c) to head (465e711).
Report is 28 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   96.21%   96.23%   +0.02%     
==========================================
  Files          35       37       +2     
  Lines         687      691       +4     
==========================================
+ Hits          661      665       +4     
  Misses         26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@samtkaplan samtkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Ieft one code comment.

@@ -0,0 +1,40 @@
using LinearAlgebra, Jets, JetPack, Test

# note no need for a linearity test as function is "linear" for x > 0 and constant for x <= 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment in error. It seems to contradict the fact that there is a linearity test below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants