fix: keep projected lines within ruled tables - #2
Closed
Chengyunlai wants to merge 2 commits into
Closed
Conversation
Chengyunlai
force-pushed
the
codex/fix-separated-grid-components
branch
from
August 13, 2026 09:23
514a2ef to
9d740a4
Compare
Owner
Author
|
Superseded by the completed projection fix now included directly in run-llama#392 at 26b79a6. The published reproduction, A/B evidence, and expanded regression coverage are documented on the upstream PR and in run-llama#414. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
PR run-llama#392 separates the vector geometry for side-by-side ruled grids, but the projection stage still groups text from both rectangles into the same line. Each ruled candidate then sees text from the adjacent table as overhang and fallback detection merges the tables again.
This follow-up uses the already-detected table rectangles as structural grouping boundaries. It does not globally change y tolerance, so ordinary multi-column text behavior is unchanged.
Reproduction
e9b56e7a3f1d990d9e1f1b63b46e5d89b8ce1afaa85c9e17a09d83d1f5563b8dOn that document, the base of run-llama#392 produces one merged 6-column table. This follow-up produces two independent 3-column Markdown tables.
Validation
cargo fmt --all -- --checkcargo test -p liteparse projected_lines_do_not_span_independent_side_by_side_tables --lib -- --nocapture(1 passed)cargo test -p liteparse --lib(295 passed)--format markdown --no-ocrDependency
This is intentionally a stacked draft based on
codex/fix-separated-grid-components, the head branch of run-llama#392. It should be retargeted or rebased after run-llama#392 is resolved.