Add alternative provider retrieval measurement #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyropy
changed the title
There was a problem hiding this comment.
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- migrations/067.do.measurement-network-retrieval.sql: Language not supported
Comments suppressed due to low confidence (1)
api/index.js:144
- Ensure that the updated SQL parameter count and ordering correctly match the columns in your INSERT statement to avoid mismatches during query execution.
$1, $2, ... $26,
This was referenced Apr 10, 2025
bajtos
reviewed
Apr 10, 2025
api/index.js
Outdated
| @@ -190,7 +209,14 @@ const getMeasurement = async (req, res, client, measurementId) => { | |||
| endAt: resultRow.end_at, | |||
| byteLength: resultRow.byte_length, | |||
| carTooLarge: resultRow.car_too_large, | |||
| attestation: resultRow.attestation | |||
| attestation: resultRow.attestation, | |||
| networkRetrieval: { | |||
There was a problem hiding this comment.
Kudos for re-creating this structure in the JSON data uploaded to Storacha! 👏🏻
Let's use the same property name as we use in spark-checker, see CheckerNetwork/spark-checker#132 (comment)
pyropy
changed the title
There was a problem hiding this comment.
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (1)
- migrations/067.do.measurement-alternative-provider-check.sql: Language not supported
Comments suppressed due to low confidence (1)
api/index.js:144
- Ensure that the updated prepared statement's parameter placeholders exactly match the number of provided values and the expected database column mappings to avoid runtime errors.
+ $1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12, $13, $14, $15, $16, $17, $18, $19, $20, $21, $22, $23, $24, $25, $26,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for new alternative-provider check measurement fields added in CheckerNetwork/spark-checker#132. New fields are saved alongside others in the
measurementstable.Closes #570
Relates to: