Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix ubuntu #1970

Merged
merged 8 commits into from
Dec 18, 2024
Merged

ci: fix ubuntu #1970

merged 8 commits into from
Dec 18, 2024

Conversation

juliangruber
Copy link
Member

@juliangruber juliangruber commented Dec 16, 2024

CI started failing, most likely due to an image update (see https://github.com/filecoin-station/desktop/actions/runs/12345143132/job/34448743776?pr=1969)

Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@juliangruber
Copy link
Member Author

CI is still failing 😢

@bajtos
Copy link
Member

bajtos commented Dec 17, 2024

> xvfb-maybe cross-env NODE_ENV=test playwright test 'test/e2e/.*.test.js'
(...)
Failed with exit code: 1
Output:


Some ideas to consider:

  • Can we configure Playwright to print more diagnostics?
  • Add another GHA step to launch the Station Desktop app in background. If our hypothesis is that the app crashes at startup, then we can launch it in the foreground (and remove this new GHA step before landing this PR).

@bajtos
Copy link
Member

bajtos commented Dec 17, 2024

Another idea: Station Desktop's electron-log writes logs to a file. Can we add a GHA step to print the contents of that log file on CI failure? I vaguely remember there is a condition to run a GHA step only when some of the previous steps failed.

@juliangruber
Copy link
Member Author

Great idea! Added via DEBUG=pw:browser*, we get this:

  pw:browser <launching> /home/runner/work/desktop/desktop/node_modules/electron/dist/electron -r /home/runner/work/desktop/desktop/node_modules/playwright-core/lib/server/electron/loader.js --inspect=0 --remote-debugging-port=0 /home/runner/work/desktop/desktop/main/index.js +0ms
  pw:browser <launched> pid=4470 +3ms
  pw:browser [pid=4470][err] [4470:1217/113040.364041:FATAL:setuid_sandbox_host.cc(163)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /home/runner/work/desktop/desktop/node_modules/electron/dist/chrome-sandbox is owned by root and has mode 4755. +26ms
  pw:browser [pid=4470] <process did exit: exitCode=null, signal=SIGTRAP> +113ms
  pw:browser [pid=4470] starting temporary directories cleanup +0ms
F°°°  pw:browser [pid=4470] finished temporary directories cleanup 

@juliangruber
Copy link
Member Author

juliangruber commented Dec 17, 2024

It is once again electron/electron#17972 (I don't know why it resurfaced)

@juliangruber juliangruber changed the title ci: fix install libsecret-1-dev ci: fix ubuntu Dec 18, 2024
@juliangruber juliangruber merged commit 054cf2a into main Dec 18, 2024
11 checks passed
@juliangruber juliangruber deleted the fix/ci-libsecret branch December 18, 2024 13:16
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants