Fix Core not having node_modules (#698)

* add `after-pack` script for macOS

* Revert "add `after-pack` script for macOS"

This reverts commit 5c67ca0.

* move core to ./core

* refactor

* fix lint

* docs

.eslintrc.json

@@ -24,7 +24,8 @@
   "ignorePatterns": [
     "assets/",
     "dist/",
-    "@types/"
+    "@types/",
+    "core/"
   ],
   "overrides": [
     {

.gitignore

@@ -32,3 +32,5 @@ dev-app-update.yml
 *.sln
 *.sw?
 .tool-versions
+
+core

electron-builder.yml

@@ -12,7 +12,8 @@ files:
     - node_modules/**/*
     - package.json
 
-asarUnpack: 'main/**/scripts/**/*'
+extraResources:
+  - 'core/**'
 
 beforePack: './build/before-pack.js'
 afterSign: './build/notarize-macos.js'

main/core.js

@@ -14,18 +14,11 @@ const { Core } = require('@filecoin-station/core')
 /** @typedef {import('./typings').Context} Context */
 /** @typedef {import('./typings').Activity} Activity */
 
-// When packaged, `app.getAppPath()` points to the ASAR archive. We need to
-// rewrite that path to the unpacked ASAR directory, where `electron-builder`
-// automatically extracted Core for us. Otherwise, Core wouldn't be able to
-// execute its binaries.
-const corePath = join(
-  app.getAppPath(),
-  'node_modules',
-  '@filecoin-station',
-  'core',
-  'bin',
-  'station.js'
-).replace('app.asar', 'app.asar.unpacked')
+// Core is installed separately from `node_modules`, since it needs a
+// self-contained dependency tree outside the asar archive.
+const corePath = app.isPackaged
+  ? join(process.resourcesPath, 'core', 'bin', 'station.js')
+  : join(__dirname, '..', 'core', 'bin', 'station.js')
 console.log('Core binary: %s', corePath)
 
 let online = false