-
Notifications
You must be signed in to change notification settings - Fork 817
Update Indonesian locale #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Update locale description - Refer to this: https://developer.chrome.com/docs/webstore/i18n/#choosing-locales-to-support
- Update locale description - Refer to this: https://developer.chrome.com/docs/webstore/i18n/#choosing-locales-to-support
da53d37
to
62a093f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Indonesian locale code from in
to id
, adds new translation keys, and corrects documentation links and badges to use README_ID.md
.
- Swap locale import/key from
in
toid
in resources - Append new translations and fix JSON in
src/_locales/id/main.json
- Update README links and badges across
README.md
,README_ZH.md
, and add improvements inREADME_ID.md
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/_locales/resources.mjs | Renamed import from in to id and updated the resources key |
src/_locales/id/main.json | Added new translation entries for Indonesian locale |
README_ZH.md | Updated Indonesia link to point at README_ID.md |
README_ID.md | Corrected badges, headings, and improved Indonesian copy |
README.md | Updated Indonesia link to README_ID.md |
Comments suppressed due to low confidence (1)
src/_locales/id/main.json:125
- Missing comma after this property causes invalid JSON once the new "Jump to bottom" entry is added; add a trailing comma here.
"Rate limit": "Batas penggunaan terlampaui"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @okkidwi,
Thank you for your contribution to improving the Indonesian localization! 🙏
Your work in updating the locale code from in
to id
, following Chrome Web Store standards, is greatly appreciated and technically correct.
However, I notice this PR has some conflicts and needs updates:
- Merge conflicts: The branch appears to be significantly behind the current master
- JSON syntax issue: There's a missing comma in
src/_locales/id/main.json
at line 125 - Branch updates: Multiple merge commits suggest the branch needs rebasing
Would you be willing to:
- Resolve the merge conflicts by rebasing against the latest master?
- Fix the JSON syntax error in the translation file?
- Clean up the commit history if possible?
This is valuable work for our Indonesian users, and I'd love to get it merged once these technical issues are resolved.
Thanks again for your contribution! Let me know if you need any assistance with the updates.
/review |
Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here. PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
/improve |
Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here. PR Code Suggestions ✨
|
Change & update locale code from IN to ID, refer to this: https://developer.chrome.com/docs/webstore/i18n/#choosing-locales-to-support