Skip to content

Update Indonesian locale #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

okkidwi
Copy link
Contributor

@okkidwi okkidwi commented Jul 7, 2023

Change & update locale code from IN to ID, refer to this: https://developer.chrome.com/docs/webstore/i18n/#choosing-locales-to-support

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Indonesian locale code from in to id, adds new translation keys, and corrects documentation links and badges to use README_ID.md.

  • Swap locale import/key from in to id in resources
  • Append new translations and fix JSON in src/_locales/id/main.json
  • Update README links and badges across README.md, README_ZH.md, and add improvements in README_ID.md

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/_locales/resources.mjs Renamed import from in to id and updated the resources key
src/_locales/id/main.json Added new translation entries for Indonesian locale
README_ZH.md Updated Indonesia link to point at README_ID.md
README_ID.md Corrected badges, headings, and improved Indonesian copy
README.md Updated Indonesia link to README_ID.md
Comments suppressed due to low confidence (1)

src/_locales/id/main.json:125

  • Missing comma after this property causes invalid JSON once the new "Jump to bottom" entry is added; add a trailing comma here.
"Rate limit": "Batas penggunaan terlampaui"

Copy link
Member

@PeterDaveHello PeterDaveHello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @okkidwi,

Thank you for your contribution to improving the Indonesian localization! 🙏

Your work in updating the locale code from in to id, following Chrome Web Store standards, is greatly appreciated and technically correct.

However, I notice this PR has some conflicts and needs updates:

  1. Merge conflicts: The branch appears to be significantly behind the current master
  2. JSON syntax issue: There's a missing comma in src/_locales/id/main.json at line 125
  3. Branch updates: Multiple merge commits suggest the branch needs rebasing

Would you be willing to:

  • Resolve the merge conflicts by rebasing against the latest master?
  • Fix the JSON syntax error in the translation file?
  • Clean up the commit history if possible?

This is valuable work for our Indonesian users, and I'd love to get it merged once these technical issues are resolved.

Thanks again for your contribution! Let me know if you need any assistance with the updates.

@PeterDaveHello
Copy link
Member

/review

Copy link

qodo-merge-pro bot commented Jun 2, 2025

Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Missing Comma

There's a missing comma at the end of line 126 after the "Jump to bottom" translation, which could cause JSON parsing errors.

  "Jump to bottom": "Lompat ke bawah"									
}
Missing Closing Brace

The closing brace for the 'id' translation object is missing proper indentation, which could lead to syntax errors.

  translation: id,
},

@PeterDaveHello
Copy link
Member

/improve

Copy link

qodo-merge-pro bot commented Jun 2, 2025

Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Impact
Possible issue
Fix missing JSON comma

Add a missing comma between the "Rate limit" entry and the "Jump to bottom"
entry. JSON requires commas between object properties, and the missing comma
will cause a syntax error.

src/_locales/id/main.json [125-126]

-"Rate limit": "Batas penggunaan terlampaui"
+"Rate limit": "Batas penggunaan terlampaui",
 "Jump to bottom": "Lompat ke bawah"
  • Apply / Chat
Suggestion importance[1-10]: 9

__

Why: This suggestion correctly identifies a critical JSON syntax error where a comma is missing between object properties. This would cause the JSON file to be invalid and fail parsing, making it a high-priority fix.

High
  • More

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants