refactor(zap): harden multi-chain zap flow and improve tx lifecycle handling#2
Open
syed-ghufran-hassan wants to merge 1 commit intoChaoLing140:mainfrom
Open
refactor(zap): harden multi-chain zap flow and improve tx lifecycle handling#2syed-ghufran-hassan wants to merge 1 commit intoChaoLing140:mainfrom
syed-ghufran-hassan wants to merge 1 commit intoChaoLing140:mainfrom
Conversation
syed-ghufran-hassan
commented
Feb 26, 2026
syed-ghufran-hassan
commented
- Replaced parseFloat math with parseUnits for safe BigInt handling
- Switched to writeContractAsync for proper async transaction control
- Centralized isProcessing state for consistent UI locking
- Simplified and standardized step management using Step type
- Improved amount validation logic
- Cleaned up error handling and state transitions
- Reduced duplicated logic across approve/deposit/finalize steps
…andling - Replaced parseFloat math with parseUnits for safe BigInt handling - Switched to writeContractAsync for proper async transaction control - Centralized isProcessing state for consistent UI locking - Simplified and standardized step management using Step type - Improved amount validation logic - Cleaned up error handling and state transitions - Reduced duplicated logic across approve/deposit/finalize steps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.