Device agnostic for DCP #19
Open
+33
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Note: stream needs to be initialized on the main thread after default cuda | ||
| # stream is setup/used to avoid the risk of accidentally reusing the main | ||
| # compute stream or in other cases kernels actually launching from the | ||
| # main thread. | ||
| self._staging_stream = torch.cuda.Stream() | ||
| self._staging_stream = torch.Stream() |
There was a problem hiding this comment.
what will happen to do sync with such stream?
There was a problem hiding this comment.
When set non-blocking=True, this stream ensure copy done. isn’t used anywhere else.
| assert torch.cuda.is_available(), "Non-blocking copy requires CUDA" | ||
| if self._config.use_non_blocking_copy: | ||
| assert torch.accelerator.is_available(), ( | ||
| "Non-blocking copy requires CUDA/XPU" |
There was a problem hiding this comment.
What's the limitation to require non-blocking? Must to be accelerator?
There was a problem hiding this comment.
non-blocking only used for copy between CPU and GPU, I assume all accelerator support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable device-agnostic implementation of DCP-related functionality, allowing the new DCP features to be supported on XPU as well.
use_cuda_non_blocking_copy to use_non_blocking_copy because non-blocking copy is supported by most GPUs and is not exclusive to CUDA devices.
Test plan: test cases have not yet been updated to be fully device agnostic; this will be addressed in future work.