Skip to content

Conversation

jacomago
Copy link
Contributor

@jacomago jacomago commented Jan 10, 2025

Adds pre-commit and github pipeline to check it
Adds the formatter and linter ruff
Fixes all the default problems from ruff
Removes legacy python 2 support
Fixes the tests and pipeline
Updates the testcontainers dependency

@jacomago jacomago self-assigned this Jan 10, 2025
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@jacomago jacomago marked this pull request as draft January 13, 2025 09:44
@jacomago jacomago force-pushed the pre-commit-ruff branch 4 times, most recently from 5eaeb79 to 5b75740 Compare January 17, 2025 15:07
@jacomago jacomago marked this pull request as ready for review January 17, 2025 15:28
@jacomago jacomago changed the title Pre-commit-ruff Modernize: Add pre-commit, ruff linting and formatting, remove python 2 support Jan 21, 2025
Copy link

@anderslindho anderslindho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but do fix the odd condition please

@jacomago jacomago force-pushed the pre-commit-ruff branch 2 times, most recently from 3b494f1 to 200145c Compare January 22, 2025 11:33
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
9 Security Hotspots
6.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@jacomago jacomago requested review from shroffk and tynanford January 22, 2025 12:15
@jacomago jacomago merged commit 2d601bb into master Feb 28, 2025
29 of 30 checks passed
@jacomago jacomago deleted the pre-commit-ruff branch February 28, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants