Skip to content

Conversation

shroffk
Copy link
Collaborator

@shroffk shroffk commented Oct 7, 2025

Break very large index and update request into smaller chunks
Address the issue #186

@jacomago
Copy link
Contributor

jacomago commented Oct 8, 2025

Oh, you're ahead of me #188

@shroffk
Copy link
Collaborator Author

shroffk commented Oct 8, 2025

An anomaly for sure...
I did make the process parallel too, it might be overkill.

@jacomago
Copy link
Contributor

jacomago commented Oct 8, 2025

An anomaly for sure... I did make the process parallel too, it might be overkill.

Yes, not sure about the parallelization. Nor using skip.

I think some combination of the two would be good. I forgot to use @value for instance

@shroffk
Copy link
Collaborator Author

shroffk commented Oct 8, 2025

Well I was trying to find the simplest way to not make copies and also support multi threading
What is your primary concern with the skip

@jacomago
Copy link
Contributor

jacomago commented Oct 9, 2025

Well I was trying to find the simplest way to not make copies and also support multi threading What is your primary concern with the skip

I just think then you have the extra loop. Wheras mine just does on loop still. But I'm not sure if it matters much.

@shroffk
Copy link
Collaborator Author

shroffk commented Oct 9, 2025

well I am hoping that the multi threaded bit means that when you have large number of channels being indexed
( like populating for performance testing, or like in ESS's case where the whole CF in wiped out an recreated ) then doing it in chunks sequentially might have some performance issues.

Adds chunking to the processing
@shroffk shroffk closed this Oct 9, 2025
@shroffk shroffk reopened this Oct 9, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants