add extra logging and skipping over bad pvs #184
Conversation
channelfinder would break with a null runtime exception here. I've added logging and allowed channelfinder to skip over bad pvs instead of breaking.
|
|
Your naming convention allows PVs with commas! 😥 Does the archiver actually handle that? Both archiving and retrieval of data? Especially the getDataAtTime api? I would really recommend URL safe pv names if you can. |
Unfortunately we have some iocs that have pvs with commas (legacy iocs) To my knowledge some of these pvs with commas are working with the archiver. It could be they are working because of aliases but I am not sure. |
|
|
||
| List<ArchivePVOptions> archivePVOptionsList = result.get(action); | ||
| if (archivePVOptionsList == null) { | ||
| logger.log(Level.WARNING, "No list found for action: {0}", action); |
There was a problem hiding this comment.
I'm not sure its possible for archivePVOptionsList to be null, see lines 194 to 195.
| logger.log(Level.WARNING, "archiverClient.getStatuses returned null"); | ||
| return result; | ||
| } | ||
| logger.log(Level.INFO, "Statuses {0}", statuses); |
There was a problem hiding this comment.
I think this should be debug level (or FINER in java logging levels). This could be massive.
| result.get(action).add(archivePVS.get(pvName)); | ||
| }); | ||
| if (statuses == null) { | ||
| logger.log(Level.WARNING, "archiverClient.getStatuses returned null"); |
There was a problem hiding this comment.
This should be impossible. If you see archiverClient.getStatusesFromPvListQuery and archiverClient.getStatusesFromPvListBody return empty lists rather than null if something goes wrong. Or they should do.
|
Have you tried with an archiver > 2.0.9 setting aa.post_support to them. I think posting the list of statuses rather than using a query should work? |
2 participants
channelfinder would break with a null runtime exception here. I've added logging and allowed channelfinder to skip over bad pvs instead of breaking.
For example, we were seeing problems populating a new archiver with channel finder and couldn't figure out why it wouldn't work with a specific ioc (it would break with null runtime exception). I added this and figured out that channelfinder was having problems archiving pvs with commas. It looks like it is splitting the pvs with commas causing channelfinder to break when getting the actions for those pvs.
Overall, functionality to fix pvs with commas still needs to be fixed but for now this lets channel finder catch bad pvs and skip over them instead of breaking.
Example:
BTS_____Q6,1___BM02:AtInjection
Aug 19 10:39:13 controls-hlc1.als.lbl.gov java[2889]: 2025-08-19 10:39:13.474 WARN 2889 --- [taskExecutor-89] o.p.c.processors.aa.AAChannelProcessor : archivePVS does not contain pvName: BTS_____Q6 Aug 19 10:39:13 controls-hlc1.als.lbl.gov java[2889]: 2025-08-19 10:39:13.474 WARN 2889 --- [taskExecutor-89] o.p.c.processors.aa.AAChannelProcessor : archivePVS does not contain pvName: 1___BM02:AtInjection