Fixed shift overflow checks and change integer literal types to ull #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelixUhle
added a commit
to FelixUhle/VERICA
that referenced
this pull request
Jan 27, 2026
- Rename README.md to README_upstream.md to preserve original docs
- Add new README.md documenting:
- Bug fixes merged from upstream PR Chair-for-Security-Engineering#5 (shift overflow, probe sizes)
- Nix/flake packaging added in this fork
- How to build with Nix
- How to use VERICA as a dependency via passthru
- Link to upstream README for full VERICA documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some more issues related to #4 . I'm still not sure if this catches all the cases, but at least it resizes some more integer literals to long long. It also moves the size check to after the virtual probes are added to ensure that it always checks against the actual size of the
extended_probesvector.