Skip to content

Use locked exact-value FX quotes for down payments - #208

Merged
Obiajulu-gif merged 1 commit into
Chainmove:mainfrom
prissca:agent/issue-176-locked-fx-quote
Aug 18, 2026
Merged

Use locked exact-value FX quotes for down payments#208
Obiajulu-gif merged 1 commit into
Chainmove:mainfrom
prissca:agent/issue-176-locked-fx-quote

Conversation

@prissca

@prissca prissca commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

What changed

  • require a locked USD/NGN quote ID for down-payment initialization
  • remove the live exchange-rate request and fallback rate from the payment mutation
  • parse requested money into exact minor units and send the immutable quoted kobo amount to Paystack
  • atomically consume locked quotes with a compare-and-set repository update
  • attach quote source, timestamps, spread, exact input/output amounts, and consumer to payment metadata

Why

The payment route previously recomputed a floating JavaScript-number conversion at mutation time, bypassing quote expiry, replay, and audit controls.

Validation

  • FX quote service tests: 7 passed, including concurrent consumption and exact-decimal boundaries
  • changed-file typecheck scan: no errors in this diff; the repository-wide baseline still has unrelated failures

Closes #176

@prissca
prissca marked this pull request as ready for review August 18, 2026 12:43
@Obiajulu-gif

Copy link
Copy Markdown
Collaborator

Thanks for the contribution! Merging this now as part of a maintainer PR sweep.

@Obiajulu-gif
Obiajulu-gif merged commit 3b9aef0 into Chainmove:main Aug 18, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[HARD][FX] Route down-payment conversion through signed, exact-value quote snapshots

2 participants