wip: Speculative Availability #7
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timwu20
changed the base branch from
master
to
tim/speculative-availability-base
timwu20
force-pushed
the
tim/speculative-availability
branch
from
1161b08 to
e7b41d4
Compare
Comment on lines
+557
to
+563
| // Get the block number for the relay_parent to update rotation_info.now | ||
| let (tx, rx) = oneshot::channel(); | ||
| sender.send_message(ChainApiMessage::BlockHeader(relay_parent, tx)).await; | ||
| let header = rx.await.map_err(|_| Error::NoSuchPoV)?.map_err(|_| Error::NoSuchPoV)?; | ||
| let block_number = header.map(|h| h.number).unwrap_or(0); // Default to 0 if not found, but should be found | ||
|
|
||
| rotation_info.now = block_number.into(); // Update now to the relay_parent's block number |
Author
There was a problem hiding this comment.
you need to manually update the rotation_info.now to update the state of GroupRotationInfo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implementation of paritytech#9444 to better understand fetching logic and backable candidate retrieval. Contains a hack in av-store to store the metadata of a chunk when receiving a store chunk request. Early requests were silently failing, since the
RunningTask.store_chunkmethod does not return a result and the error was not logged out correctly.