Skip to content

feat(prospective-parachains): introduce GetHypotheticalMembership handler #4641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Apr 24, 2025

Conversation

EclesioMeloJunior
Copy link
Member

@EclesioMeloJunior EclesioMeloJunior commented Apr 3, 2025

Changes

  • Introduce HypotheticalOrConcrete interface
  • Changes fragment tree checkPotential to receive the interface
  • Handle incomming GetHypotheticalMembership requests
  • Include a ahead verification for candidates not included in the candidate storage, before we were just returning, now we check if this potential candidate meets the constraints

Tests

go test -timeout 30s github.com/ChainSafe/gossamer/dot/parachain/prospective-parachains -run ^TestGetHypotheticalMembership$ -v

Issues

…andler

- Introduce `HypotheticalOrConcrete` interface
- Changes fragment tree `checkPotential` to receive the interface
- Handle incomming `GetHypotheticalMembership` requests
@EclesioMeloJunior EclesioMeloJunior marked this pull request as draft April 3, 2025 19:02
@EclesioMeloJunior EclesioMeloJunior marked this pull request as ready for review April 4, 2025 15:50
Copy link
Member

@freddyli7 freddyli7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! just one question

Copy link
Contributor

@axaysagathiya axaysagathiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊

@EclesioMeloJunior EclesioMeloJunior merged commit 26e3b57 into feat/parachain Apr 24, 2025
22 checks passed
@EclesioMeloJunior EclesioMeloJunior deleted the eclesio/get-hypotetical-membership branch April 24, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants