Skip to content

feat(rpc): Filecoin.StateCompute #5488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 1, 2025
Merged

feat(rpc): Filecoin.StateCompute #5488

merged 7 commits into from
Apr 1, 2025

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Mar 31, 2025

Summary of changes

Changes introduced in this pull request:

➜  car_db forest-tool api compare forest_snapshot_calibnet_2025-03-31_height_2536410.forest.car.zst --n-tipsets 20 --filter StateCompute
| RPC Method                 | Forest | Lotus |
|----------------------------|--------|-------|
| Filecoin.StateCompute (20) | Valid  | Valid |
| RPC Method | Forest | Lotus |
|------------|--------|-------|

and lotus-shed miner fees now works with Forest

Reference issue to close (if applicable)

Closes #5477

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review March 31, 2025 16:47
@hanabi1224 hanabi1224 requested a review from a team as a code owner March 31, 2025 16:47
@hanabi1224 hanabi1224 requested review from lemmih and elmattic and removed request for a team March 31, 2025 16:47
@elmattic
Copy link
Contributor

No ✅, no review 🚫.

@hanabi1224
Copy link
Contributor Author

No ✅, no review 🚫.

All green now

type Params = (ChainEpoch, Vec<Message>, ApiTipsetKey);
type Ok = ComputeStateOutput;

async fn handle(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might make sense to add this command to the filter list, given it can be quite costly. https://docs.forest.chainsafe.io/guides/methods_filtering#public-rpc-node-recommendations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@elmattic elmattic added this pull request to the merge queue Apr 1, 2025
Merged via the queue into main with commit e6c72f0 Apr 1, 2025
42 checks passed
@elmattic elmattic deleted the hm/state-compute branch April 1, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPC method Filecoin.StateCompute is missing
4 participants