feat(wallets): keyExportFormats schema, column metadata and validation (DBIP #3725) - #3742
Open
foxxx009 wants to merge 1 commit into
Open
feat(wallets): keyExportFormats schema, column metadata and validation (DBIP #3725)#3742foxxx009 wants to merge 1 commit into
foxxx009 wants to merge 1 commit into
Conversation
…num, uniqueness and ordering validation (DBIP Chain-Love#3725)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3725 (tools side)
Problem
The
keyExportboolean cannot distinguish what can actually be backed up or migrated: an account private key, a mnemonic and an encrypted application backup are different artifacts.Changes
tools/schema.json: optionalkeyExportFormatsproperty onwallets— JSON array or null, items restricted to the initial enumencrypted-backup/mnemonic/raw-private-key,uniqueItems: true.meta/columns.json:keyExportFormatsmetadata (arrayPopover, security group, searchableMultiSelect filter).tools/csv_to_json.py:validate_key_export_formats()— rejects nonarrays, unknown/case-mismatched names and duplicates, enforces canonical alphabetical ordering; wired into canonical offers and every expanded network listing.Validation covered (per DBIP #3725 §Acceptance)
[](explicit review found none) both acceptedvalidate_csv.py→csv_to_json.py→validate.pyall green locallyThe existing
keyExportboolean is untouched (no rename, no bulk rewrite). Data side: paired PR adds the column to the 92 wallet tables and seeds a single verified Algorand cell (Pera).Rewards address: 0x2409b47a530be3831158f10b08ac93f7d08c1ff2