feat(wallets): extensionBrowsers schema, column metadata and validation (DBIP #3713) - #3740
Open
foxxx009 wants to merge 1 commit into
Open
feat(wallets): extensionBrowsers schema, column metadata and validation (DBIP #3713)#3740foxxx009 wants to merge 1 commit into
foxxx009 wants to merge 1 commit into
Conversation
…queness and ordering validation (DBIP Chain-Love#3713)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3713 (tools side)
Problem
supportedPlatformsidentifies delivery formats (e.g. "Browser Extension"), not the desktop browser products a provider currently supports, so users cannot answer "does this wallet have a maintained Firefox extension?" from the data.Changes
tools/schema.json: optionalextensionBrowsersproperty onwallets— JSON array or null, items restricted to the initial vocabularyBrave/Chrome/Edge/Firefox/Opera/Safari,uniqueItems: true.meta/columns.json:extensionBrowsersmetadata (arrayPopover, capabilities group, searchableMultiSelect filter).tools/csv_to_json.py:validate_extension_browsers()— rejects nonarrays, unknown/lowercase names and duplicates, and enforces canonical alphabetical ordering; wired into both canonical offers and every expanded network listing.Validation covered (per DBIP #3713 §Migration 5)
[]accepted (explicit: no desktop extension documented)["Brave","Chrome","Edge","Firefox","Opera"]accepted["Chrome"]acceptedvalidate_csv.py→csv_to_json.py→validate.pyall green locally)Data side: paired PR adds the column to the 92 wallet tables and seeds only the two evidence-backed canonical rows.
Rewards address: 0x2409b47a530be3831158f10b08ac93f7d08c1ff2