Skip to content

data(filecoin): document blstrs default dependencies - #3739

Merged
eugene17kotov merged 3 commits into
Chain-Love:mainfrom
TataneSan:data/filecoin-blstrs-dependencies
Sep 9, 2026
Merged

data(filecoin): document blstrs default dependencies#3739
eugene17kotov merged 3 commits into
Chain-Love:mainfrom
TataneSan:data/filecoin-blstrs-dependencies

Conversation

@TataneSan

Copy link
Copy Markdown
Contributor

Change

Fill the empty dependencies cell for filecoin-blstrs with its direct runtime dependencies under default Cargo features. The existing Filecoin listing already references this offer.

Source: Cargo.toml at 4cc0dcb, checked September 9, 2026. Cargo's implicit caret requirements are written explicitly. pairing_lib is recorded under the actual package name pairing; serde is included because the default feature enables it. GPU-only ec-gpu and dev dependencies are excluded. No automation-reserved version, release-date, maintainer or license fields are changed.

Verification

  • CSV parsing and row-width check passed.
  • Checked nine dependency entries, untouched automation-reserved fields and the existing Filecoin offer reference.
  • python3 git-hooks/pre-commit.py passed CSV validation, JSON generation and generated schema validation. It emitted unrelated chain warnings for Zilliqa, Lightning and Camino. Unrelated sorting changes introduced by the hook were removed from this PR.

Prepared with AI assistance. This is one improved cell, not nine separately billable changes.

Reward request

Please consider this under discussion #41's Filecoin bounty rules; eligibility and amount remain subject to your review. USDC/USDT receiving address on Ethereum mainnet: 0x646B15039c0c4a122B5d4ec031bd085e172BCD7a.

Copilot AI lite review requested due to automatic review settings September 9, 2026 11:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a narrow, well-formed single-row CSV update consistent with existing dependencies formatting and does not affect reserved fields.

Pull request overview

This PR updates the Chain.Love CSV-first dataset by documenting the default (runtime) dependency set for the existing filecoin-blstrs offer entry, improving downstream consumers’ ability to understand and visualize Filecoin’s Rust SDK/library dependency footprint.

Changes:

  • Filled the previously-empty dependencies cell for filecoin-blstrs in references/offers/sdks.csv.
  • Left automation-reserved metadata fields (latestKnownVersion, latestKnownReleaseDate, maintainer, license) unchanged/empty as before.
File summaries
File Description
references/offers/sdks.csv Populates filecoin-blstrs dependencies with a structured list of direct default-feature runtime dependencies.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@USS-Supervisor USS-Supervisor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST_CHANGES
Risk: MEDIUM
Summary: The edit surface is narrow and the CSV structure is clean, but the new filecoin-blstrs dependency list is incomplete against the commit-pinned Cargo.toml cited in the PR. Please add the missing direct default dependency before approval.
Findings:

  • MEDIUM references/offers/sdks.csv:67 (filecoin-blstrs.dependencies): the cited filecoin-project/blstrs Cargo.toml at 4cc0dcb49ee441ce3d6090cd88a9bfdcb4b4a3db has zeroize = "1.8.2" in [dependencies], and it is not optional. The PR's dependency array omits it. Please add zeroize@^1.8.2 to the JSON list, keeping the existing normalized package@version-range format.
    Confidence: HIGH

This reverts commit 6ad2212.
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Summary

Status Count
🔍 Total 1
🔗 Unique 1
✅ Successful 1
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 0
❓ Unknown 0
🚫 Errors 0
⛔ Unsupported 0

Full Github Actions output

@USS-Supervisor USS-Supervisor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE
Risk: LOW
Summary: Current head ded4485 restores the missing zeroize dependency. The one-cell CSV change is structurally clean, the dependency list matches the commit-pinned Cargo.toml, and validation plus the current-cycle link-check both passed.
Findings: None.
Confidence: HIGH

@eugene17kotov
eugene17kotov merged commit 751cab4 into Chain-Love:main Sep 9, 2026
3 checks passed
@eugene17kotov

Copy link
Copy Markdown
Collaborator

@TataneSan
Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants