data(filecoin): document blstrs default dependencies - #3739
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change is a narrow, well-formed single-row CSV update consistent with existing dependencies formatting and does not affect reserved fields.
Pull request overview
This PR updates the Chain.Love CSV-first dataset by documenting the default (runtime) dependency set for the existing filecoin-blstrs offer entry, improving downstream consumers’ ability to understand and visualize Filecoin’s Rust SDK/library dependency footprint.
Changes:
- Filled the previously-empty
dependenciescell forfilecoin-blstrsinreferences/offers/sdks.csv. - Left automation-reserved metadata fields (
latestKnownVersion,latestKnownReleaseDate,maintainer,license) unchanged/empty as before.
File summaries
| File | Description |
|---|---|
| references/offers/sdks.csv | Populates filecoin-blstrs dependencies with a structured list of direct default-feature runtime dependencies. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: REQUEST_CHANGES
Risk: MEDIUM
Summary: The edit surface is narrow and the CSV structure is clean, but the new filecoin-blstrs dependency list is incomplete against the commit-pinned Cargo.toml cited in the PR. Please add the missing direct default dependency before approval.
Findings:
- MEDIUM
references/offers/sdks.csv:67(filecoin-blstrs.dependencies): the citedfilecoin-project/blstrsCargo.tomlat4cc0dcb49ee441ce3d6090cd88a9bfdcb4b4a3dbhaszeroize = "1.8.2"in[dependencies], and it is not optional. The PR's dependency array omits it. Please addzeroize@^1.8.2to the JSON list, keeping the existing normalizedpackage@version-rangeformat.
Confidence: HIGH
This reverts commit 6ad2212.
Summary
|
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Risk: LOW
Summary: Current head ded4485 restores the missing zeroize dependency. The one-cell CSV change is structurally clean, the dependency list matches the commit-pinned Cargo.toml, and validation plus the current-cycle link-check both passed.
Findings: None.
Confidence: HIGH
|
@TataneSan |
Change
Fill the empty
dependenciescell forfilecoin-blstrswith its direct runtime dependencies under default Cargo features. The existing Filecoin listing already references this offer.Source: Cargo.toml at 4cc0dcb, checked September 9, 2026. Cargo's implicit caret requirements are written explicitly.
pairing_libis recorded under the actual package namepairing;serdeis included because the default feature enables it. GPU-onlyec-gpuand dev dependencies are excluded. No automation-reserved version, release-date, maintainer or license fields are changed.Verification
python3 git-hooks/pre-commit.pypassed CSV validation, JSON generation and generated schema validation. It emitted unrelated chain warnings for Zilliqa, Lightning and Camino. Unrelated sorting changes introduced by the hook were removed from this PR.Prepared with AI assistance. This is one improved cell, not nine separately billable changes.
Reward request
Please consider this under discussion #41's Filecoin bounty rules; eligibility and amount remain subject to your review. USDC/USDT receiving address on Ethereum mainnet:
0x646B15039c0c4a122B5d4ec031bd085e172BCD7a.