feat(apis): optional structured requestLimits column (DBIP #3724, tools side) - #3738
Open
foxxx009 wants to merge 1 commit into
Open
feat(apis): optional structured requestLimits column (DBIP #3724, tools side)#3738foxxx009 wants to merge 1 commit into
foxxx009 wants to merge 1 commit into
Conversation
…ck span) DBIP Chain-Love#3724 implementation on the tools side: - schema.json: optional apis property requestLimits — array of objects {method, transport(http|websocket), metric(batchRequests|blockSpan), maximum(positive int), sourceUrl}; additionalProperties false; optional so existing rows stay valid. - meta/columns.json: requestLimits metadata (arrayPopover, capabilities). - csv_to_json.py: validate_request_limits() run once on canonical offers and per network on resolved apis listings — enforces exact key set, enum transports/metrics, positive integer maximum, http(s) sourceUrl and (method, transport, metric) uniqueness. Blank/None stays valid: blank means unverified, no 0 sentinel or guessed unlimited. Local run: csv_to_json.py exit 0 on current data; validate.py green; negative cases (duplicate tuple, maximum 0, bad transport/metric/url) all rejected with per-row messages.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tools-side implementation of DBIP #3724 (data PR: #3737).
Changes (by file)
tools/schema.json: optionalapis.requestLimits- array of objects with exact keysmethod,transport(http|websocket),metric(batchRequests|blockSpan),maximum(positive integer),sourceUrl;additionalProperties: false. Optional, so existing rows without the column stay valid.meta/columns.json:requestLimitsmetadata (arrayPopover, capabilities group, documented blank-means-unverified semantics).tools/csv_to_json.py:validate_request_limits()run on canonical offers once and on resolved apis listings per network. Enforces: exact key set, enum transports/metrics, positive integer maximum (no 0 sentinel, no guessed unlimited), http(s) sourceUrl, and(method, transport, metric)uniqueness within one row. Blank/None always valid.Acceptance
(method, transport, metric)uniqueness enforcedValidation run locally
csv_to_json.pyexit 0 on current data (schemaVersion 2.0.0 generated for all 155 networks)validate.pygreen against the updated schema(method, transport, metric)tuple,maximum: 0,transport: "smtp",metric: "rateLimit", non-URLsourceUrlRewards address: 0x2409b47a530be3831158f10b08ac93f7d08c1ff2