Enforce unique provider slugs (closes #3628) - #3712
Open
Karlhezenberg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a uniqueness validation for provider slugs in
csv_to_json.py. Previously, two providers with the same slug would silently overwrite each other during JSON generation. Now, a deterministicValueErroris raised listing the duplicated slug values.This reuses the existing
build_index_by_slug()function already used for offer slug validation — no new function was written.Changes
tools/csv_to_json.py: Added one line callingbuild_index_by_slug(providers, ...)after loading providers, before building the provider-by-name indextools/test_provider_slugs.py: New unit test file with 13 tests covering:build_index_by_slug(): unique slugs, empty lists, duplicates rejected, error message content, whitespace handlingload_providers()+build_index_by_slug(): integration with CSV filescsv_to_json.pymain(): full integration testTests
All existing tests unchanged and green. New tests verify:
providers.csvloads without duplicate slugsFooter
Closes #3628