Snapshot - #831
Open
OluRemiFour wants to merge 2 commits into
Open
Conversation
Author
|
Done, Close: #831 |
Gbangbolaoluwagbemiga
force-pushed
the
main
branch
3 times, most recently
from
July 22, 2026 16:51
32f43f6 to
f15d961
Compare
Contributor
|
@OluRemiFour , ci pipeline failed, please pull from upstream and resolve the ci, a major fix has been commit to the main branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #761
Summary of the change
I've created comprehensive tooling for reviewing and approving insta snapshot diffs to ensure detector changes are transparent.
Created Components
review-snapshots.ps1 - A streamlined review tool with:
-TestOnly - Run snapshot tests to detect changes
-ListPending - List all pending snapshot files with size comparisons
-Review - Interactive review with diff display for each change
-AcceptAll/-RejectAll - Bulk operations (with confirmation)
-DetectorsOnly - Filter to detector snapshots only
2. Comprehensive Documentation
SNAPSHOT_REVIEW_WORKFLOW.md - Complete guide covering:
Quick start for both script and cargo-insta workflows
Understanding what triggers snapshot changes
How to read and interpret snapshot diffs
Step-by-step review process with best practices
CI integration details
Troubleshooting common scenarios
Guidelines for adding new detectors
3. Enhanced CI Integration
Updated ci.yml to:
Add clearer comments explaining snapshot testing purpose
Reference the new review script and documentation
Add a failure step that provides actionable guidance when snapshot tests fail
4. Updated Existing Documentation
Enhanced README.md to:
Reference the new review script as the recommended approach
Link to the comprehensive workflow documentation
Maintain cargo-insta direct usage as an alternative
Usage Example
PowerShell
Detect changes
.\scripts\review-snapshots.ps1 -TestOnly
Review interactively
.\scripts\review-snapshots.ps1 -Review
Review only detectors
.\scripts\review-snapshots.ps1 -Review -DetectorsOnly
The tooling ensures detector changes are transparent by requiring human review of snapshot diffs before they can be merged, with clear documentation and CI enforcement.
Fixes / Closes
Fixes #761
Motivation and context
Dependencies
Type of change
How Has This Been Tested?
Test A
Test B
Checklist: