Skip to content

Conversation

Johnetordoff
Copy link
Contributor

Purpose

Changes

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify
  • Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

https://openscience.atlassian.net/browse/ENG-8988

Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is a good fix but I don't think this fix what QA pointed out in the ticket.

@Johnetordoff Johnetordoff force-pushed the fix/notification-contrib-template branch from 95d668b to 8ea82ca Compare September 19, 2025 13:43
@Johnetordoff
Copy link
Contributor Author

@cslzchen I see now, it looked like it was effecting other templates too. I left a little too much sentence in the template.

Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't think your changes fix the issue and you may have accidentally changed the right template. Can you try to search for You can access this draft by to locate the right template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants