Skip to content

Conversation

mkovalua
Copy link
Contributor

@mkovalua mkovalua commented Sep 8, 2025

Purpose

Frequently users inadvertently include personal identifying information in files associated with Registrations. It becomes imperative for these files to be removed as soon as possible. While any solution to https://openscience.atlassian.net/browse/ENG-8547 would also solve this issue, the most important piece of that analysis is the removal of the file containing the personal identifying information. This function is currently only able to be completed by a Cloud engineer, enabling this function in the admin app would reduce Cloud engineer time and allow for faster resolution to user mistakes with including personal identifying information in files.

Changes

implementation of business logic and UI to delete specified file by guid

image
Screen.Recording.2025-09-09.at.17.06.41.1.mp4

QA Notes

  1. After registration is archived file should be deleted from registration files UI tab on admin panel delete action
  2. After registration is archived file should be deleted from registration overview UI tab on admin panel delete action
  3. After registration is archived file should not be deleted from registration associated project

What are the areas of risk?

Any concerns/considerations/questions that development raised?

image

not confident about

reg.registration_responses = reg.schema_responses.latest('created').all_responses
reg.registered_meta[reg.registered_schema._id] = reg.expand_registration_responses()

usage

it looks like

image

reg.registered_meta[reg.registered_schema._id] may be used properly only for DraftRegistration for now

and reg.schema_responses.latest('created') will raise Not Exist error if there is no record

maybe try: except approach is ok, maybe some additional logic is expected

Documentation

Side Effects

Ticket

https://openscience.atlassian.net/browse/ENG-8740

antkryt and others added 20 commits August 15, 2025 14:46
…nterForOpenScience#11246)

* remove csrf protection from reset password endpoint

* update test
[ENG-8656] Clean up password reset throttle error
…x/ENG-8743

[ENG-8743] subscribe_osf_general_email settings is not updated
…#11271)

* use same logic for admin and web password reset

* fix tests
…x/ENG-8742

[ENG-8742] include ignored components when create a view-only link
@mkovalua mkovalua marked this pull request as draft September 8, 2025 14:22
@mkovalua mkovalua marked this pull request as ready for review September 9, 2025 14:14
@adlius adlius changed the base branch from feature/pbs-25-16 to feature/pbs-25-19 September 18, 2025 04:53
@adlius
Copy link
Collaborator

adlius commented Sep 18, 2025

@mkovalua Could you rebase this onto the latest feature/pbs-25-19 branch?

1 similar comment
@adlius
Copy link
Collaborator

adlius commented Sep 18, 2025

@mkovalua Could you rebase this onto the latest feature/pbs-25-19 branch?

@mkovalua
Copy link
Contributor Author

hi @adlius, I have resolved merge conflicts with feature/pbs-25-19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants