Skip to content

[ENG-7965] Add v2 confirmation endpoint #11139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: feature/pbs-25-10
Choose a base branch
from

Conversation

Johnetordoff
Copy link
Contributor

Purpose

Update the alternate email confirmation system to v2

Changes

  • add /users/<user_id>/confirm/ route with views
  • adds tests

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify
  • Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

https://openscience.atlassian.net/browse/ENG-7965

@@ -442,7 +442,7 @@ class Meta:
type_ = 'user_reset_password'


class ExternalLoginConfirmEmailSerializer(BaseAPISerializer):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor because it's now shared

@Johnetordoff Johnetordoff force-pushed the add-v2-confirmation-endpoint branch from 7e94e44 to 74cb85e Compare May 13, 2025 14:50
@Johnetordoff Johnetordoff changed the title [WIP][ENG-7965] Add v2 confirmation endpoint [ENG-7965] Add v2 confirmation endpoint May 13, 2025
@Johnetordoff Johnetordoff force-pushed the add-v2-confirmation-endpoint branch from 74cb85e to 0343e5f Compare May 13, 2025 16:13
@Johnetordoff Johnetordoff force-pushed the add-v2-confirmation-endpoint branch from 0343e5f to 08de7be Compare May 13, 2025 16:19
@Johnetordoff Johnetordoff marked this pull request as ready for review May 13, 2025 16:20
@brianjgeiger brianjgeiger changed the base branch from feature/pbs-25-09 to feature/pbs-25-10 May 16, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant