Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue: service-api failed to run on gce env created by test-setup.sh #98

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

sonyafenge
Copy link
Collaborator

@sonyafenge sonyafenge commented Jul 21, 2022

fix issue: #97

and also fix another small error: fix ip_dissplay error when resource num==0

verified on gce with the scenarios below, both can start service successfully:

  1. 1 server instance and 2 simulator instance, server instance created by managed instance group
  2. 2 server instance and 2 simulator instance, servers created by individual vm instances.

@sonyafenge sonyafenge requested a review from q131172019 July 21, 2022 17:38
fix ip_dissplay error when resource num==0
@sonyafenge sonyafenge force-pushed the pr-fixserviceerrorongce branch from 04fda7e to 11a3e1d Compare July 21, 2022 17:43
Copy link
Collaborator

@q131172019 q131172019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@yb01 yb01 merged commit 6809794 into CentaurusInfra:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants